Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change php required version in composer.json #905

Merged
merged 1 commit into from Mar 13, 2021
Merged

Change php required version in composer.json #905

merged 1 commit into from Mar 13, 2021

Conversation

adoy
Copy link
Contributor

@adoy adoy commented Mar 10, 2021

Future versions of PHP (8.1, 9, ...) might break the code.
We need to be more specific on the list of supported php versions and
add the new versions when they will be released and tested.

@codecov
Copy link

codecov bot commented Mar 10, 2021 •
edited

Codecov Report

Merging #905 (9058cd9) into master (00d65f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #905   +/-   ##
=========================================
  Coverage     72.25%   72.25%           
  Complexity      874      874           
=========================================
  Files            31       31           
  Lines          2447     2447           
=========================================
  Hits           1768     1768           
  Misses          679      679

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00d65f3...9058cd9. Read the comment docs.

ramunasd
ramunasd reviewed Mar 11, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@adoy
Change php required version in composer.json
9058cd9 
Future versions of PHP (8.1, 9, ...) might break the code.
We need to be more specific on the list of supported php versions and
add the new versions when they will be released and tested.
@javer
Copy link
Contributor

javer commented Mar 12, 2021

This tiny change will make big struggle on the end of November 2021 when PHP 8.1 is going to be released, delaying ability to use new PHP version of many PHP developers by at least 3 months or even more (12 March 2021 - 26 Nov 2020 = 3 month 2 weeks). Neither of the library I know uses such a strict (and short-term) PHP version constraint. Take a look at PHP version constraint strategy of other widely used libraries - these guys know something:

@michaelklishin
Copy link
Collaborator

November 2021 is not far off but also not exactly coming next month, so this seems to be fair to me. Doctrine ORM currently supports 7.2 and 8.0, Symfony supports anything later than 7.2. Perhaps 8.1 can be considered shortly before it goes GA.

@michaelklishin
Copy link
Collaborator

This change makes sense to me. We can always easily whitelist 8.1 and any future versions as they go GA.

@michaelklishin michaelklishin merged commit 4128d61 into php-amqplib:master Mar 13, 2021
@michaelklishin
Copy link
Collaborator

Thank you!

This was referenced Mar 17, 2021
Closed
Open
Merged
Merged
github-actions bot pushed a commit to umbrellio/php-table-sync that referenced this pull request Mar 19, 2021
@dependabot
Updates the requirements on [php-amqplib/php-amqplib](https://github.…
9434d3c 
…com/php-amqplib/php-amqplib) to permit the latest version.

<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/php-amqplib/php-amqplib/blob/master/CHANGELOG.md">php-amqplib/php-amqplib's changelog</a>.</em></p>
<blockquote>
<h2>3.0.0 - 2021-03-16</h2>
<p>This version introduces PHP8 compatibility.</p>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/1?closed=1">GitHub Milestone</a></p>
<h2>2.12.2 - 2021-02-12</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/18?closed=1">GitHub Milestone</a></p>
<h2>2.12.1 - 2020-08-24</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/17?closed=1">GitHub Milestone</a></p>
<h2>2.12.0 - 2020-08-24</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/14?closed=1">GitHub Milestone</a></p>
<h2>2.11.3 - 2020-05-13</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/16?closed=1">GitHub Milestone</a></p>
<h2>2.11.2 - 2020-04-30</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/15?closed=1">GitHub Milestone</a></p>
<h2>2.11.1 - 2020-02-24</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/13?closed=1">GitHub Milestone</a></p>
<h2>2.11.0 - 2019-11-19</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/12?closed=1">GitHub Milestone</a></p>
<h2>2.10.1 - 2019-10-10</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/11?closed=1">GitHub Milestone</a></p>
<h2>2.10.0 - 2019-08-09</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/10?closed=1">GitHub Milestone</a></p>
<ul>
<li>Heartbeats are disabled by default. This reverts the following changes: <a href="https://github.com/php-amqplib/php-amqplib/issues/563">Issue</a> / <a href="https://github.com/php-amqplib/php-amqplib/pull/648">PR</a></li>
</ul>
<h2>2.9.2 - 2019-04-24</h2>
<p><a href="https://github.com/php-amqplib/php-amqplib/milestone/9?closed=1">GitHub Milestone</a></p>
<h2>2.9.1 - 2019-03-26</h2>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/c0a8eade209b7e43d6a405303d8de716dfd02749"><code>c0a8ead</code></a> 3.0.0 CHANGELOG</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/516c504c9c35c70d32762612f90ac1164a179e88"><code>516c504</code></a> fix missing scrutinizer code coverage data</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/4128d6132f34e3661f5831849633c0b015a0f700"><code>4128d61</code></a> Merge pull request <a href="https://github.com/php-amqplib/php-amqplib/issues/905">#905</a> from adoy/composer-php-requirement</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/9058cd92bab62b6ef55b4463cc854cb6c695074e"><code>9058cd9</code></a> Change php required version in composer.json</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/00d65f30f567062de00e666a5cb5c7daef9f47b1"><code>00d65f3</code></a> use appveyor rabbitmq install scripts from organization library</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/12d094b325564306610ced32bee0815219377607"><code>12d094b</code></a> 3.0.0-rc2</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/89372d57584cd39827c459a3dd5f5134cc5b1912"><code>89372d5</code></a> Merge pull request <a href="https://github.com/php-amqplib/php-amqplib/issues/904">#904</a> from patrickkusebauch/master</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/83048dc8f1b9444100e9dcea6472294dc3efbb23"><code>83048dc</code></a> 3.0.0 CHANGELOG</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/8fce64cc321b0dee395409bedf2b36493c01a1bf"><code>8fce64c</code></a> fix</li>
<li><a href="https://github.com/php-amqplib/php-amqplib/commit/f15ec3c10b578ab869a3d17dd4b9d74aaeb0424d"><code>f15ec3c</code></a> fix</li>
<li>Additional commits viewable in <a href="https://github.com/php-amqplib/php-amqplib/compare/v2.8.0...v3.0.0">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
kratkyzobak pushed a commit to kratkyzobak/php-amqplib that referenced this pull request Feb 9, 2024
@michaelklishin
Merge pull request php-amqplib#905 from adoy/composer-php-requirement
f0cd2a8 
Change php required version in composer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramunasd ramunasd ramunasd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adoy @javer @michaelklishin @ramunasd