New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Snapshot Versions #269
Conversation
Hi, @dasrecht , thanks for the PR. According to https://bugs.php.net/bug.php?id=67804:
Instead of removing, what do you think to update the urls for the ones available on GitHub? We could use the function Example of a definition in repo that is using already the Probably it would be something like this:
Can rebase your PR, or send a new one? Let us know if you need some help with it, ok? Thanks! |
Oh @dasrecht , perhaps it can help, the branches in https://github.com/php/php-src/branches:
|
Hi there. Yes taking on the branches of php-src sounds like a splendid idea! I'll reroll my PR to make that happen. |
Ok! Let us know when it's ready for reviewing. See ya! |
Ping @dasrecht. This is a blocker for our v1.0.0 release. |
This reverts commit 12f51e9.
uh, sorry for that. i'm on that right away! |
fixed :) |
👍 |
Could you squash to one commit please, then 👍 from me. Alternatively, we can squash it manually on merge. |
Hi Graham, can you squash it at merge please? I think it's easier than redoing the whole PR. Thanks! |
👍🏻 |
Merged. Thank you. :) |
Closes php-build#269 Signed-off-by: Graham Campbell <graham@mineuk.com>
Hi There
I removed the snapshot definitions since snaps.php.net has gone away.
I could not find another solution to snaps.php.net unfortunately.
/bastian