Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Snapshot Versions #269

Closed
wants to merge 3 commits into from
Closed

Fixing Snapshot Versions #269

wants to merge 3 commits into from

Conversation

dasrecht
Copy link
Contributor

@dasrecht dasrecht commented Apr 1, 2015

Hi There

I removed the snapshot definitions since snaps.php.net has gone away.

I could not find another solution to snaps.php.net unfortunately.

/bastian

@rogeriopradoj
Copy link
Member

Hi, @dasrecht , thanks for the PR.

According to https://bugs.php.net/bug.php?id=67804:

[2015-02-18 21:07 UTC] jacob@php.net
Hi,
http://snaps.php.net has be decomissioned in favour of the git snapshots
available at https://github.com/php/php-src.

Instead of removing, what do you think to update the urls for the ones available on GitHub?

We could use the function install_package_from_github https://github.com/CHH/php-build/blob/master/bin/php-build#L473 that is already available.

Example of a definition in repo that is using already the install_package_from_github: https://github.com/CHH/php-build/blob/master/share/php-build/definitions/master#L1

Probably it would be something like this:

install_package_from_github PHP-5.4
install_pyrus
install_xdebug "2.3.2"

Can rebase your PR, or send a new one? Let us know if you need some help with it, ok?

Thanks!

@rogeriopradoj
Copy link
Member

Oh @dasrecht , perhaps it can help, the branches in https://github.com/php/php-src/branches:

  • PHP-5.6
  • PHP-5.5
  • PHP-5.4

@dasrecht
Copy link
Contributor Author

dasrecht commented Apr 7, 2015

Hi there. Yes taking on the branches of php-src sounds like a splendid idea! I'll reroll my PR to make that happen.

@rogeriopradoj
Copy link
Member

Ok! Let us know when it's ready for reviewing.

See ya!

@GrahamCampbell GrahamCampbell mentioned this pull request Apr 16, 2015
@GrahamCampbell
Copy link
Member

Ping @dasrecht. This is a blocker for our v1.0.0 release.

@GrahamCampbell GrahamCampbell changed the title Removing Snapshot Versions Fixing Snapshot Versions Apr 16, 2015
@dasrecht
Copy link
Contributor Author

uh, sorry for that. i'm on that right away!

@dasrecht
Copy link
Contributor Author

fixed :)

@rogeriopradoj
Copy link
Member

👍

@GrahamCampbell
Copy link
Member

Could you squash to one commit please, then 👍 from me. Alternatively, we can squash it manually on merge.

@dasrecht
Copy link
Contributor Author

Hi Graham, can you squash it at merge please? I think it's easier than redoing the whole PR.

Thanks!

@CHH
Copy link
Member

CHH commented Apr 19, 2015

👍🏻

@GrahamCampbell
Copy link
Member

Merged. Thank you. :)

mlocher pushed a commit to mlocher/php-build that referenced this pull request May 15, 2015
Closes php-build#269

Signed-off-by: Graham Campbell <graham@mineuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants