New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-patch code for APXS handling #353

Merged
merged 2 commits into from Dec 11, 2015

Conversation

Projects
None yet
3 participants
@ikari7789
Contributor

ikari7789 commented Dec 11, 2015

Improves upon #204.

No longer any need for the manual patching of the Makefile as it can be done with sed and no longer applies to PHP7 (which always causes a Makefile.rej file to be created.)
This patch will put both the apache mod_php module in the phpenv folder rather than attempting to write it directly into the Apache folder, which may require root permission and is better to be managed separately for each PHP install.

tkak and others added some commits Jun 30, 2014

Remove hard-patch code for APXS handling
Improves upon #204.

No longer any need for the manual patching of the Makefile as it can be done with sed and no longer applies to PHP7 (which always causes a Makefile.rej file to be created.)
This patch will put both the apache mod_php module in the phpenv folder rather than attempting to write it directly into the Apache folder, which may require root permission and is better to be managed separately for each PHP install.

rogeriopradoj added a commit that referenced this pull request Dec 11, 2015

Merge pull request #353 from ikari7789/patch-2
Remove hard-patch code for APXS handling - Closes #204

@rogeriopradoj rogeriopradoj merged commit cba25e2 into php-build:master Dec 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rogeriopradoj

This comment has been minimized.

Show comment
Hide comment
@rogeriopradoj
Member

rogeriopradoj commented Dec 11, 2015

Thanks @ikari7789 !

@0livier

This comment has been minimized.

Show comment
Hide comment
@0livier

0livier commented Dec 11, 2015

Sweet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment