Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 Support #599

Merged
merged 28 commits into from Dec 9, 2019
Merged

PHP 7.4 Support #599

merged 28 commits into from Dec 9, 2019

Conversation

ruudboon
Copy link
Contributor

@ruudboon ruudboon commented Dec 6, 2019

PHP 7.4 support Linux is working. Osx has some issue, but looks like this already happing in the main repo as well.

@ruudboon
Copy link
Contributor Author

ruudboon commented Dec 6, 2019

@GrahamCampbell Looks like it will be hard to build on Trusty. Lot of deps aren't available anymore.
Is there a reason why everything is still on Ubuntu 14?

@ruudboon ruudboon marked this pull request as ready for review December 6, 2019 16:58
@ruudboon ruudboon changed the title [WIP] PHP 7.4 Support PHP 7.4 Support Dec 6, 2019
@GrahamCampbell
Copy link
Member

Is there a reason why everything is still on Ubuntu 14?

Because it breaks when we try Ubuntu 16.04 or 18.04, and we never looked into fixing the travis config. We'd be happy to test on any version of Ubuntu. There's no reason we've fixed it at 14.04, other than we didn't upgrade it.

@GrahamCampbell GrahamCampbell merged commit 4687bb4 into php-build:php74 Dec 9, 2019
BanzaiMan added a commit to travis-ci/php-src-builder that referenced this pull request Dec 9, 2019
This reverts commit 0e41179.

php-build has recently added 7.4 support, so we'll use that instead.

php-build/php-build#599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants