New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psr6SessionHandler | Remove wrong InvalidArgumentException throw in doc #107

Closed
prisis opened this Issue May 19, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@Nyholm

This comment has been minimized.

Show comment
Hide comment
@Nyholm

Nyholm May 19, 2017

Member

What exception should be thrown? The session handler does not have a dependency on cache/common. It is also built for ANY PSR 6 cache.

Member

Nyholm commented May 19, 2017

What exception should be thrown? The session handler does not have a dependency on cache/common. It is also built for ANY PSR 6 cache.

@prisis

This comment has been minimized.

Show comment
Hide comment
@prisis

prisis May 19, 2017

Member

I said to remove the wrong exception info, we dont throw a exception in __construct function or add one with options checks

Member

prisis commented May 19, 2017

I said to remove the wrong exception info, we dont throw a exception in __construct function or add one with options checks

@Nyholm

This comment has been minimized.

Show comment
Hide comment
@Nyholm

Nyholm May 19, 2017

Member
Member

Nyholm commented May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment