New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix cache addapter is not PSR-16 compliant. #111

Closed
ndobromirov opened this Issue Jul 10, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@ndobromirov

ndobromirov commented Jul 10, 2017

See declaration...

class PrefixedCachePool implements CacheItemPoolInterface

The simple cache interface is completely missing. It is present on Memcache, as it extends the AbstractCachePool base utility.

class MemcachedCachePool extends AbstractCachePool implements HierarchicalPoolInterface
@prisis

This comment has been minimized.

Show comment
Hide comment
@prisis

prisis Jul 10, 2017

Member

Hey :), maybe you have some time to add a new PrefixedSimpleCache class?

Member

prisis commented Jul 10, 2017

Hey :), maybe you have some time to add a new PrefixedSimpleCache class?

@Nyholm

This comment has been minimized.

Show comment
Hide comment
@Nyholm

Nyholm Jul 10, 2017

Member

👍

Member

Nyholm commented Jul 10, 2017

👍

@ndobromirov

This comment has been minimized.

Show comment
Hide comment
@ndobromirov

ndobromirov Jul 11, 2017

Why not just extend the AbstractCachePool and make PrefixedCachePool work with both as all other cache adapters?

ndobromirov commented Jul 11, 2017

Why not just extend the AbstractCachePool and make PrefixedCachePool work with both as all other cache adapters?

@ndobromirov ndobromirov reopened this Jul 11, 2017

@prisis

This comment has been minimized.

Show comment
Hide comment
@prisis

prisis Jul 11, 2017

Member

Because PrefixedCachePool is a wrapper for PSR-6 and not a adapter

Member

prisis commented Jul 11, 2017

Because PrefixedCachePool is a wrapper for PSR-6 and not a adapter

@ndobromirov

This comment has been minimized.

Show comment
Hide comment
@ndobromirov

ndobromirov Jul 12, 2017

So let's have some progress on this :) php-cache/cache#171
Implementation is based on the other prefixed decorator.
There is some code duplication that could be moved to a trait (maybe).

ndobromirov commented Jul 12, 2017

So let's have some progress on this :) php-cache/cache#171
Implementation is based on the other prefixed decorator.
There is some code duplication that could be moved to a trait (maybe).

@prisis prisis closed this Nov 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment