New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should inherit from AbstractPoolCache #113

Open
alarofrunetotem opened this Issue Sep 14, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@ghost

ghost commented Sep 14, 2017

If you have an expensive cache and later decide to mix it with a faster cache (i.e.filesystem and memcache) you cant just plug in this class as a drop in replacement because it does not inherits from AbstractPoolCache. It also misses the PSR-16 compatibility (beause it's implemented in AbstractPoolCache.

@prisis

This comment has been minimized.

Show comment
Hide comment
@prisis

prisis Nov 8, 2017

Member

Hey @alarofrunetotem can you tell my the name of the class, i dont see which class it is?

Member

prisis commented Nov 8, 2017

Hey @alarofrunetotem can you tell my the name of the class, i dont see which class it is?

@alar77

This comment has been minimized.

Show comment
Hide comment
@alar77

alar77 Nov 8, 2017

(Writing from my work account now)
Sorry, I didnt notice issues are at php-cache level (and not for single driver).
I was referring to the chain-adapter.

alar77 commented Nov 8, 2017

(Writing from my work account now)
Sorry, I didnt notice issues are at php-cache level (and not for single driver).
I was referring to the chain-adapter.

@hytest

This comment has been minimized.

Show comment
Hide comment
@hytest

hytest Mar 14, 2018

I have same problem on NamespacedCachePool, it doesn't inherit from AbstractPoolCache so I can't call invalidateTags.

hytest commented Mar 14, 2018

I have same problem on NamespacedCachePool, it doesn't inherit from AbstractPoolCache so I can't call invalidateTags.

@prisis

This comment has been minimized.

Show comment
Hide comment
@prisis

prisis Mar 14, 2018

Member

Yeah the NamespacedCachePool is missing some functions, i will work this weekend on phpcache, but im happy about a pr

Member

prisis commented Mar 14, 2018

Yeah the NamespacedCachePool is missing some functions, i will work this weekend on phpcache, but im happy about a pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment