Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Documentation in Cache bundle allows level configuration #122

Open
lnesi opened this issue Jan 4, 2018 · 1 comment
Open

Logging Documentation in Cache bundle allows level configuration #122

lnesi opened this issue Jan 4, 2018 · 1 comment

Comments

@lnesi
Copy link

@lnesi lnesi commented Jan 4, 2018

At http://www.php-cache.com/en/latest/symfony/cache-bundle/#logging

The level properties is not implemented at:

https://github.com/php-cache/cache-bundle/blob/b0b54bbe4f7fbd23f0dcf5eb53c6f1d4a605a702/src/DependencyInjection/Configuration.php#L141-L154

    private function addLoggingSection()
    {
        $tree = new TreeBuilder();
        $node = $tree->root('logging');

        $node
            ->canBeEnabled()
            ->addDefaultsIfNotSet()
            ->children()
                ->scalarNode('logger')->defaultValue('logger')->end()
            ->end();

        return $node;
    }
@lnesi
Copy link
Author

@lnesi lnesi commented Jan 4, 2018

Also reviewing more into details in the AnstractCachePool.php the log is only executed when exceptions happen and not to all interactions as shown on the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.