Result of pdepend plugin is not accessible

[SimonHeimberg]

The charts generated by pdepend plugin are not accessible by any url because they are not in public directory nor any controller handles this.
The pdepend plugin prints a link. But when visiting it, a 404 error is shown of course.

[corpsee]

I Will try to fix it. Thanks!

[corpsee]

dancryer/PHPCI#93

[awkward-minion]

Hello @corpsee ,
Is there any workaround for this ?

[corpsee]

@lakshmajim Now I guess you may make /runtime/builds directory public in nginx/apache configuration. But it isn't good idea.

[SimonHeimberg]

I understand that dancryer/PHPCI#93 mentions the same problem.
What they did is to display the images on the build page (in dancryer/PHPCI@39e9d94), but the printed url is still invalid.

[corpsee]

@SimonHeimberg Thank you for the link ( dancryer/PHPCI@39e9d94)!

I think we can solve the problem by special rout (controller/action) which will return files for pdepend (like BuildStatusController::image returns status image).

[vinpel]

Additionaly the documentation miss a yaml example of the plugin.

[corpsee]

This is an important note, thank you @vinpel! #143

[corpsee]

@SimonHeimberg @lakshmajim Fixed in branch improve-pdepend. Can you check it please?

[corpsee]

Merged into master. Feel free to reopen and comment.

[SimonHeimberg]

Confirm that the url shown in the log works.

What we do not have is a link pointing always to the newest generated version. (This would have been the functionality of the original shown link. But it did not work.) In case somebody would like to include the link in the readme, as the log text tells. (I would prefer a link to the newest version of a branch anyway. Maybe create a symlink?)

Should we mention ...

• that files in the artifacts directory will not be deleted when the build (or project) is deleted from php-censor?
• that the output files are readable without login? (OK, this is expected here, else a link to an image would not work.)

[corpsee]

@SimonHeimberg You say reasonable things and questions. Now I know what to do next, thank you. 👍

1. Link to the latest build in each branch is needed.
2. Project artifacts directory deleting when deleted project is needed.
3. I think that it is OK because it is a static content, but may be we should make direct links more random (Some hash instead of project/build ids).

[SimonHeimberg]

Note to 3. (output files readable without login):

• This is expected for phpmd. Else it is not possible to include the generated images in an online README.md.
• This is maybe unexpected for code coverage of phpunit. The coverage results show the entire source code. This is no problem for FOSS projects, but for others. A warning sounds apropriate.

[corpsee]

Done.

1. Added links for the last build of branch (for PHPUnit and PDepend artifacts).
2. Application remove artifacts when removed build or project.
3. Now names of the directories is more random.

@SimonHeimberg Can you check changes in the branch artifacts? Thanks!

[corpsee]

Added global application config (config.yml) option php-censor.build.allow_public_artifacts for allow/deny to generate public artifacts.

[corpsee]

Now in master branch.