New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the --xml flag to the end of the command #230

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
2 participants
@jwmwalrus
Contributor

jwmwalrus commented Nov 9, 2018

Contribution type

  • Bug fix

Description of change

The --xml flag can, optionally, get the name of the report to be generated.

When the args passed to PHP Censor for the Codeception plugin start with a non-flag (e.g., if the value of test.codeception.args is "acceptance --coverage-html --html", then the codeception will end up running all the suites (instead of running only the desired one), and generating an XML report named tests/_output/acceptance.

Since PHP Censor looks explicitly for tests/{_output,_log}/report.xml, the test step will always fail.

Therefore, it's safer to insert the --xml flag at the end.

@corpsee corpsee merged commit 3914f9b into php-censor:master Nov 9, 2018

3 of 4 checks passed

codecov/patch 0% of diff hit (target 26.94%)
Details
PHP Censor PHP Censor build passed.
Details
codecov/project 26.94% remains the same compared to 240e580
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@corpsee

This comment has been minimized.

Member

corpsee commented Nov 9, 2018

@jwmwalrus 👍

@jwmwalrus jwmwalrus deleted the jwmwalrus:xml-flag branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment