Symfony security checker #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeimberg
force-pushed
the
symfony_security_checker
branch
from
a909c83
to
06f848f
Compare
corpsee
reviewed
Mar 18, 2020
SimonHeimberg
commented
Mar 18, 2020
SimonHeimberg
commented
Mar 18, 2020
src/Plugin/SecurityChecker.php
Outdated
| @@ -91,6 +91,8 @@ public function execute() | |||
| if ($this->allowedWarnings != -1 && ($result->count() > $this->allowedWarnings)) { | |||
| $success = false; | |||
| } | |||
| } elseif (null === $warnings && $result) { | |||
| $this->builder->logWarning('invalid json: '.$result); | |||
There was a problem hiding this comment.
maybe throwing a RuntimeException (or another Exception) would be better.
There was a problem hiding this comment.
@SimonHeimberg Yes, throwing a RuntimeException would be great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution type
improvement
Description of change
Security checker can be configured to use the binary
symfony(as recommended by https://github.com/FriendsOfPHP/security-advisories#checking-for-vulnerabilities).