Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony security checker #358

Merged
merged 3 commits into from Mar 20, 2020

Conversation

@SimonHeimberg
Copy link
Contributor

SimonHeimberg commented Mar 17, 2020

Contribution type

improvement

Description of change

Security checker can be configured to use the binary symfony (as recommended by https://github.com/FriendsOfPHP/security-advisories#checking-for-vulnerabilities).

@SimonHeimberg SimonHeimberg force-pushed the SimonHeimberg:symfony_security_checker branch from a909c83 to 06f848f Mar 17, 2020
@@ -91,6 +91,8 @@ public function execute()
if ($this->allowedWarnings != -1 && ($result->count() > $this->allowedWarnings)) {
$success = false;
}
} elseif (null === $warnings && $result) {
$this->builder->logWarning('invalid json: '.$result);

This comment has been minimized.

Copy link
@SimonHeimberg

SimonHeimberg Mar 18, 2020

Author Contributor

maybe throwing a RuntimeException (or another Exception) would be better.

This comment has been minimized.

Copy link
@corpsee

corpsee Mar 18, 2020

Member

@SimonHeimberg Yes, throwing a RuntimeException would be great.

@corpsee corpsee assigned SimonHeimberg and unassigned corpsee Mar 19, 2020
@corpsee corpsee merged commit e1d6ead into php-censor:master Mar 20, 2020
2 of 4 checks passed
2 of 4 checks passed
codecov/patch 0% of diff hit (target 27%)
Details
codecov/project 27% (+-0%) compared to 29f9dbd
Details
PHP Censor PHP Censor build passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@corpsee

This comment has been minimized.

Copy link
Member

corpsee commented Mar 20, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.