From db5b4c265b36063a6c7485eabae3265f939de616 Mon Sep 17 00:00:00 2001 From: Slava Semushin Date: Wed, 24 Apr 2024 07:38:40 +0700 Subject: [PATCH] chore: don't test Go implementation for 500 errors As we don't have a generic error handler, there is no reason to have a test for such behavior. Part of #48 --- .github/workflows/integration-tests.yml | 5 +++++ tests/misc.hurl | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index 3a94c79..b0489e0 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -34,15 +34,19 @@ jobs: - docker-service-name: 'express-js' database-service-name: 'mysql' application-port: 3010 + skip_500_error_testing: false - docker-service-name: 'express-ts' database-service-name: 'mysql' application-port: 3020 + skip_500_error_testing: false - docker-service-name: 'chi' database-service-name: 'mysql' application-port: 3030 + skip_500_error_testing: true - docker-service-name: 'fastapi' database-service-name: 'postgres' application-port: 4040 + skip_500_error_testing: false env: # Prevent interference between builds by setting the project name to a unique value. Otherwise # "docker compose down" has been stopping containers (especially database) from other builds. @@ -92,6 +96,7 @@ jobs: hurl \ --error-format long \ --variable SERVER_URL=http://127.0.0.1:${{ matrix.application-port }} \ + --variable skip_500_error_testing=${{ matrix.skip_500_error_testing }} \ --test \ tests/crud.hurl \ tests/misc.hurl diff --git a/tests/misc.hurl b/tests/misc.hurl index ba2e3e7..45b2cc5 100644 --- a/tests/misc.hurl +++ b/tests/misc.hurl @@ -2,7 +2,7 @@ # Tests for various operations # # How to run: -# hurl --variable SERVER_URL=http://127.0.0.1:3000 misc.hurl --test +# hurl --variable SERVER_URL=http://127.0.0.1:3000 --variable skip_500_error_testing=false misc.hurl --test # @@ -14,6 +14,8 @@ jsonpath "$.custom" == true GET {{ SERVER_URL }}/custom/exception +[Options] +skip: {{ skip_500_error_testing }} HTTP 500 [Asserts] header "Content-Type" contains "application/json"