Remove AttributesSniff to fix conflict with Slevomat ReferenceUsedNamesOnly #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PhpCollective\Sniffs\Commenting\AttributesSniffwhich required FQCN for PHP 8 attributesProblem
The
AttributesSniffrequired fully qualified class names (FQCN) for PHP 8 attributes, e.g.:However, this conflicts with
SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnlywhich requires using short names via use statements:When both rules are active,
phpcbfenters an infinite loop:AttributesSniffconverts to FQCNReferenceUsedNamesOnlyconverts back to short name with use statementSolution
Remove the
AttributesSniffto resolve this conflict. This aligns with the modern PHP convention of using short names with use statements for better:Test plan
🤖 Generated with Claude Code