Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with doctrine/doctrine-bundle v2 #984

Closed
likeuntomurphy opened this issue Nov 21, 2019 · 1 comment
Closed

Incompatibility with doctrine/doctrine-bundle v2 #984

likeuntomurphy opened this issue Nov 21, 2019 · 1 comment

Comments

@likeuntomurphy
Copy link

@likeuntomurphy likeuntomurphy commented Nov 21, 2019

The enqueue/enqueue package is incompatible with Doctrine bundle v2 when used with Symfony because Symfony\Bridge\Doctrine\RegistryInterface is no longer aliased to the doctrine service (https://github.com/doctrine/DoctrineBundle/blob/master/UPGRADE-2.0.md#service-aliases).

Argument 1 passed to Enqueue\Doctrine\DoctrineConnectionFactoryFactory::__construct() must be an instance of Symfony\Bridge\Doctrine\RegistryInterface, instance of Doctrine\Bundle\DoctrineBundle\Registry given

I downgraded the Doctrine bundle to 1.6, but then the ServiceEntityRepository class from the v2 Doctrine bundle is unavailable, and I am relying on it.

I don’t know what the milestones are for the enqueue package, so I don’t really know what the exact solution is to maintain BC. For the time being, I am planning on forking the repo and changing the typehint from Symfony\Bridge\Doctrine\RegistryInterface to Doctrine\Common\Persistence\ManagerRegistry.

@likeuntomurphy likeuntomurphy changed the title symfony-bundle incompatible with doctrine/doctrine-bundle v2 Incompatibility with doctrine/doctrine-bundle v2 Nov 21, 2019
@Steveb-p

This comment has been minimized.

Copy link
Contributor

@Steveb-p Steveb-p commented Nov 21, 2019

From what I see removal of this interface is the only major thing that makes Doctrine bundle 2.0 incompatible. You can fork and make PR with necessary changes to make it work.

ctrl-f5 added a commit to ctrl-f5/enqueue-dev that referenced this issue Nov 22, 2019
ctrl-f5 added a commit to ctrl-f5/enqueue-dev that referenced this issue Nov 25, 2019
@makasim makasim closed this in 85c005f Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.