New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqs] Dead Letter Queue Adoption #720

Merged
merged 4 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@cshum
Copy link
Contributor

cshum commented Jan 11, 2019

Per #475, current Sqs requeue behaviour deletes the message and create another one.

This is not desirable because SQS lost track of Receive count, hence unable to adopt dead letter queue.

Changes made to terminte visibility timeout instead:
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-visibility-timeout.html#terminating-message-visibility-timeout

Todo:

  • Fix Tests

@cshum cshum changed the title [sqs] Dead Letter Queue Adoption #475 [sqs] Dead Letter Queue Adoption Jan 11, 2019

@makasim

This comment has been minimized.

Copy link
Member

makasim commented Jan 13, 2019

Thanks for the contribution @cshum. Could you please fix the failing test https://travis-ci.org/php-enqueue/enqueue-dev/jobs/478393876 ?

@makasim makasim added the enhancement label Jan 13, 2019

cshum added some commits Jan 14, 2019

@cshum

This comment has been minimized.

Copy link
Contributor

cshum commented Jan 14, 2019

@makasim unit test fixed. Please review, thanks.

@makasim makasim merged commit cc69df2 into php-enqueue:master Jan 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment