Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#984 Symfony 4.4 compatibility #985

Closed
wants to merge 1 commit into from

Conversation

@ctrl-f5
Copy link
Contributor

ctrl-f5 commented Nov 22, 2019

Fix fox issue #984 and Symfony 4.4 compatibility

see symfony/symfony#32394

Copy link
Contributor

DamienHarper left a comment

You should use Doctrine\Common\Persistence\ManagerRegistry instead of https://github.com/doctrine/DoctrineBundle/blob/master/UPGRADE-2.0.md#service-aliases

@@ -2,16 +2,16 @@
namespace Enqueue\Doctrine;
use Doctrine\Bundle\DoctrineBundle\Registry;

This comment has been minimized.

Copy link
@DamienHarper

DamienHarper Nov 22, 2019

Contributor

You should use Doctrine\Common\Persistence\ManagerRegistry instead as noted in the upgrade doc

This comment has been minimized.

Copy link
@ctrl-f5

ctrl-f5 Nov 25, 2019

Author Contributor

updated to ManagerRegistry

@ctrl-f5 ctrl-f5 force-pushed the ctrl-f5:984-symfony-4-4 branch from 32d2c07 to fca4b3b Nov 25, 2019
@luca-simonetti

This comment has been minimized.

Copy link

luca-simonetti commented Nov 27, 2019

any ETA on this to be merged?

@Steveb-p

This comment has been minimized.

Copy link
Contributor

Steveb-p commented Nov 27, 2019

any ETA on this to be merged?

As mentioned in #988 it should be soon, probably tomorrow. In the meantime you can use the workaround described there to see if it will work in your project and maybe spot any issues.

@ctrl-f5

This comment has been minimized.

Copy link
Contributor Author

ctrl-f5 commented Nov 27, 2019

I'll close this one since it's been superseded by #988

@ctrl-f5 ctrl-f5 closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.