Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up#984 Symfony 4.4 compatibility #985
Closed
Conversation
|
You should use |
| @@ -2,16 +2,16 @@ | |||
| namespace Enqueue\Doctrine; | |||
| use Doctrine\Bundle\DoctrineBundle\Registry; | |||
This comment has been minimized.
This comment has been minimized.
DamienHarper
Nov 22, 2019
Contributor
You should use Doctrine\Common\Persistence\ManagerRegistry instead as noted in the upgrade doc
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
luca-simonetti
commented
Nov 27, 2019
|
any ETA on this to be merged? |
This comment has been minimized.
This comment has been minimized.
As mentioned in #988 it should be soon, probably tomorrow. In the meantime you can use the workaround described there to see if it will work in your project and maybe spot any issues. |
This comment has been minimized.
This comment has been minimized.
|
I'll close this one since it's been superseded by #988 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ctrl-f5 commentedNov 22, 2019
Fix fox issue #984 and Symfony 4.4 compatibility
see symfony/symfony#32394