Skip to content

Updated php-etl contract versions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Dec 19, 2023
Merged

Updated php-etl contract versions #6

merged 13 commits into from
Dec 19, 2023

Conversation

sebprt
Copy link
Collaborator

@sebprt sebprt commented Nov 20, 2023

No description provided.

@sebprt sebprt added the GTM Good to merge label Nov 20, 2023
@sebprt sebprt requested a review from gplanchat November 20, 2023 14:07
@sebprt sebprt self-assigned this Nov 20, 2023
@sebprt sebprt added WIP Work in Progress and removed GTM Good to merge labels Nov 22, 2023
gplanchat
gplanchat reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@gplanchat gplanchat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SI ton PHPStan est corrigé au niveau 5, passes la CI en niveau 5 minimum et modifies le fichier README.

@sebprt sebprt added the GTM Good to merge label Nov 22, 2023
@sebprt sebprt requested a review from gplanchat November 22, 2023 16:04
@sebprt sebprt removed the WIP Work in Progress label Nov 22, 2023
clemzarch
clemzarch reviewed Nov 23, 2023
View reviewed changes
JoMessina
JoMessina approved these changes Nov 23, 2023
View reviewed changes
JoMessina
JoMessina reviewed Nov 23, 2023
View reviewed changes
Copy link

@JoMessina JoMessina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vois qu'il n'y a pas de MSI et de coverage MSI minimum de configuré pour Infection. Il faut peut-être définir des pourcentages pour avoir une pertinence sur ce check ?

JoMessina
JoMessina reviewed Nov 23, 2023
View reviewed changes
Copy link

@JoMessina JoMessina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarque concernant les workflow github. Sur l'action phpstan 5 dans quality tu set un php_version qui n'est pas fait ailleurs. Est-ce obligatoire ou pas ? Il faut peut-être normaliser ici.

JoMessina
JoMessina reviewed Nov 23, 2023
View reviewed changes
Copy link

@JoMessina JoMessina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarque concernant les workflow github. Sur l'action phpstan 5 dans quality tu set un php_version qui n'est pas fait ailleurs. Est-ce obligatoire ou pas ? Il faut peut-être normaliser ici.

@sebprt
Copy link
Collaborator Author

sebprt commented Nov 23, 2023

Je vois qu'il n'y a pas de MSI et de coverage MSI minimum de configuré pour Infection. Il faut peut-être définir des pourcentages pour avoir une pertinence sur ce check ?

C'est ajouté

@sebprt sebprt force-pushed the feature/update-contracts branch from c6b2272 to 52a0754 Compare November 24, 2023 09:12
gplanchat
gplanchat requested changes Nov 29, 2023
View reviewed changes
@sebprt sebprt requested a review from gplanchat November 30, 2023 08:19
@gplanchat gplanchat merged commit c6ed8a3 into main Dec 19, 2023
@gplanchat gplanchat deleted the feature/update-contracts branch December 19, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemzarch clemzarch clemzarch left review comments

@gplanchat gplanchat gplanchat approved these changes

@JoMessina JoMessina JoMessina approved these changes

Assignees

@sebprt sebprt

Labels
GTM Good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebprt @gplanchat @clemzarch @JoMessina