Add Parameter & Return Types (versions 3 of the library) #24
Conversation
|
I've force-pushed. This rebases the iterable document types to be the first commit, so that all proposed releases include them. |
This is a breaking change since implementations without return types are considered to be "widening" them, which is not allowed in PHP. Implementations that implement v3, however, are also implementing v1 and v2 as of PHP 7.4, so such implementations can use a require statement of `^1|^2|^3`. Usage libraries also can use a require statement of `^1|^2|^3`
|
I've force pushed. This rebase updates the commit messages and the composer.json files to align with recent edits to the meta document |
navarr
changed the title
|
Can you mention me once this MR is merged please ? I need to prepare the next major update of Phpfastcache, thanks 👼🏻 |
|
Everything looks good here, I think. Just some issues on the spec PR itself. |
|
Hello @Crell, not wanting to be pressing or anything but this seems to take much longer than it took for the PSR-6 to make the PHP-8 type upgrade ? Thanks again :) |
|
I'm not ok with having this in a single PR before calling a vote. We need two separate PR/branches, to have a clear separation of the proposed tags. |
Can the concerned people make the changes and proceed to the vote ? This "simple" upgrade for PHP 8 is during for almost five months now. It's in the FIG's interest to be proactive and do the good things to improve interoperability for PHP community. Thank you @Jean85 🙏🏻 |
Jean85
changed the title
|
I've done it myself, by splitting this into #25 and changing the base here. I'll try to call a vote ASAP. |
|
As long as things are addressed, as per |
|
@Jean85 Why are the PRs split? Do we need two separate votes for these changes? |
No but we will need two different releases, so we need to make the CC able to review those separately. And us to tag separately, too. |
|
Closed by mistake (stupid automations!) Vote has passed: https://groups.google.com/g/php-fig/c/DJ8ysB1JV4Y Releasing this as 3.0.0 now. |
|
Yes, finally 🥳 🎉 Thanks for that and sorry for pushing again and again, I will have some work this weekend :D |
|
@Jean85 can you create the Github releases after pushing tags too ? Thank you ! |
|
@Geolim4 done! |
Please see php-fig/fig-standards#1252 for an explanation