Add Parameter Types (versions 2 of the library) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change since consumers may be providing entities that can be converted to a string. Implementations that implement v2, however, are also implementing v1 as of PHP 7.2, so such implementations can use a require statement of `^1|^2`. Usage libraries also can use a require statement of `^1|^2` so long as they are passing the specific variable type
This was referenced Oct 6, 2021
Closed
|
I think that's reasonable. Modulo making sure we don't break Symfony again. 😅 |
Closed
|
The only issue that that kind of upgrade creates is the same that we encountered in php-fig/container#33 as you said, breaking Symfony. That issue is a bug only on PHP < 7.4 and since we're requiring 8 here, we would be good to go! |
navarr
approved these changes
Oct 6, 2021
|
Hello, php-fig/fig-standards#1252 has been merged, can this MR be merged too ? (As well as #24 ?) |
|
Vote has passed: https://groups.google.com/g/php-fig/c/DJ8ysB1JV4Y Releasing this as 2.0.0 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a split of #24, to make it more clear what the end result of the new tags will be, so we can vote on it.