Gettext\Extractors\Mo parsing plural messages.

[acgrid]

Hi,
The procedure in Gettext\Extractors\Mo seems to extract basic string without split singular/plural strings delimited by NULL character.

From https://github.com/oscarotero/Gettext/blob/master/Gettext/Extractors/Mo.php#L52

        for ($i = 0; $i < $total; $i++) {
            $stream->seekto($table_originals[$i * 2 + 2]);
            $original = $stream->read($table_originals[$i * 2 + 1]);

            if ($original) {
                $stream->seekto($table_translations[$i * 2 + 2]);
                $entries->insert(null, $original)->setTranslation($stream->read($table_translations[$i * 2 + 1]));
            }
        }

This my workaround, while it looks a bit ugly and not very safe.

if ($original) {
    $stream->seekto($table_translations[$i * 2 + 2]);
    $original = explode("\000",$original);
    $translated = explode("\000",$stream->read($table_translations[$i * 2 + 1]));
    $singular = $original[0];
    $plural = isset($original[1]) ? $original[1] : '';
    $translation = $entries->insert(null, $original[0], $plural);
    $translation->setTranslation($translated[0]);
    if($plural) $translation->setPluralTranslation(isset($translated[1]) ? $translated[1] : $translated[0]);
}

Thanks in advance.

[oscarotero]

Thank you, @acgrid
I've implemented your code. Please, can you tell me whether it works fine? I am not a .mo format expert :)

[acgrid]

Thanks for your reply.
Hmm, I just read specification of MO file today.
In my projects, the plural messages work fine in both languages with and without plural form.
I'll report here if anything wrong found.

[oscarotero]

Great.
I going to create a new release with these changes.