Skip to content

Conversation

@mlocati
Copy link
Member

@mlocati mlocati commented Feb 16, 2016

This will fail...

@mlocati
Copy link
Member Author

mlocati commented Feb 16, 2016

...but the next commit should fix this problem 😉

oscarotero added a commit that referenced this pull request Feb 16, 2016
@oscarotero oscarotero merged commit aa05bf4 into php-gettext:master Feb 16, 2016
@oscarotero
Copy link
Member

Good job. Thank you very much!

@mlocati mlocati deleted the test-multibyte-and-tab branch February 16, 2016 19:41
@mlocati
Copy link
Member Author

mlocati commented Feb 16, 2016

I still have to review the po loader, since there too we should be sure to correctly parse the input strings... Tomorrow I will

@oscarotero
Copy link
Member

👍

@mlocati
Copy link
Member Author

mlocati commented Feb 19, 2016

PS: I just performed the following test on 50+ languages, each with 4000+ strings (including languages that make great use of multibyte chars like Arabic, Greek, Hebrew, Japanese, Persian, Russian, Simplified Chinese, Traditional Chinese, Vietnamese...)

  1. Load .po file generated with GNU gettext tools
  2. Save to a new .po file
  3. compare both files with msgcat -u to look for differences between the two

Result? No difference has been found.

That means that oscarotero/Gettext correctly reads and writes .po files 😉

@oscarotero
Copy link
Member

Amazing 👯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants