Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Release AddPathPlugin fix in 1.9.x #171
AddPathPlugin was broken in 1.x and fixed in 2.x branch.
AddPathPlugin must be fixed in 1.x branch too.
Steps to Reproduce
Release AddPathPlugin fix in 1.x branch. For 3rd-party developers fix of this plugin will be simpler than adopting to 2.x. Currently I'm using https://github.com/janephp/open-api-runtime/ which depends to ^1.4.
David, already did. But its weird.…
if i remember correctly, we did this only for master because the behaviour changes slightly. i would recommend that you copy the plugin into your application namespace and configure it as a service and register it with the client. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#171 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEwnVZ-RDUJIB-pEvQhjRuQgJauzK_Cks5vVMtsgaJpZM4bnGkj> .
i think this is one of those borderline cases where its not a straight up bug fix but a fix that can have a different unexpected behaviour. however, i notice now that we did not label #141 as BC break.
@php-http/httplug how do you think about backporting that fix to version 1? if memory serves me correctly, we started out on 2.0 because we wanted to do that thing with a marker header on the request to know if we already saw the request...
Didn't we decide that if we make any changes to AddPathPlugin we would exclude one use-case. There are no solution that would fix all problems. That is why we left it as it was and recommended people to implement their own AddPathPlugin if their edge case was not covered.