fix guzzle test suite #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2020
dbu
approved these changes
Feb 4, 2020
| $testCases = parent::getInvalidHeaderArguments(); | ||
|
|
||
| // Guzzle accepts false as value for BC | ||
| unset($testCases[3]); |
There was a problem hiding this comment.
could we name the test cases to make this more robust? (if a data provider uses array keys for the test sets, phpunit also logs that when a test fails, so instead of "failed with data set 3" you would see "failed with data set 'set to false'")
There was a problem hiding this comment.
phpunit also outputs the value (false). so naming it does not improve it. but I can do so if you prefer
There was a problem hiding this comment.
i think it is more robust in this place here when you can unset the specific named test, instead of "index 3", so i'd prefer if you can name them.
|
thanks for the work! if you have time to do the named provider items it would be nice, but did not consider it a blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip test not suitable for guzzle. Replaces #40. The remaining failure will be resolved with guzzle/psr7#317