Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix guzzle test suite #43

Merged
merged 1 commit into from Feb 5, 2020
Merged

fix guzzle test suite #43

merged 1 commit into from Feb 5, 2020

Conversation

@Tobion
Copy link
Contributor

Tobion commented Feb 3, 2020

Skip test not suitable for guzzle. Replaces #40. The remaining failure will be resolved with guzzle/psr7#317

@Tobion Tobion force-pushed the Tobion:guzzle-tests branch from 0408d42 to 22308d1 Feb 3, 2020
@dbu
dbu approved these changes Feb 4, 2020
Copy link
Contributor

dbu left a comment

thanks! i commented on some minor details, hopefully you can adjust those?

src/ServerRequestIntegrationTest.php Show resolved Hide resolved
src/ServerRequestIntegrationTest.php Show resolved Hide resolved
$testCases = parent::getInvalidHeaderArguments();

// Guzzle accepts false as value for BC
unset($testCases[3]);

This comment has been minimized.

Copy link
@dbu

dbu Feb 4, 2020

Contributor

could we name the test cases to make this more robust? (if a data provider uses array keys for the test sets, phpunit also logs that when a test fails, so instead of "failed with data set 3" you would see "failed with data set 'set to false'")

This comment has been minimized.

Copy link
@Tobion

Tobion Feb 4, 2020

Author Contributor

phpunit also outputs the value (false). so naming it does not improve it. but I can do so if you prefer

This comment has been minimized.

Copy link
@dbu

dbu Feb 5, 2020

Contributor

i think it is more robust in this place here when you can unset the specific named test, instead of "index 3", so i'd prefer if you can name them.

@dbu dbu merged commit 7c963b6 into php-http:master Feb 5, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/styleci/pr The analysis has passed
Details
@dbu

This comment has been minimized.

Copy link
Contributor

dbu commented Feb 5, 2020

thanks for the work!

if you have time to do the named provider items it would be nice, but did not consider it a blocker.

@Tobion Tobion deleted the Tobion:guzzle-tests branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.