From 2777607e54763dca5fc7910afd35855d028cd3fd Mon Sep 17 00:00:00 2001 From: Chemaclass Date: Sat, 1 Aug 2026 23:42:32 +0200 Subject: [PATCH] chore: drop Scrutinizer Its coverage node errors on PHP 8.3 and the build logs are not publicly readable, so the check is red without being actionable. GitHub Actions already runs php-cs-fixer, Psalm, PHPStan and PHPUnit on 8.3/8.4/8.5, and coverage is available locally via composer test-coverage. Removes .scrutinizer.yml, both README badges and the docs reference. --- .scrutinizer.yml | 28 ---------------------------- CHANGELOG.md | 1 + README.md | 6 ------ docs/development.md | 2 +- 4 files changed, 2 insertions(+), 35 deletions(-) delete mode 100644 .scrutinizer.yml diff --git a/.scrutinizer.yml b/.scrutinizer.yml deleted file mode 100644 index 941702a..0000000 --- a/.scrutinizer.yml +++ /dev/null @@ -1,28 +0,0 @@ -build: - environment: - php: 8.3 - nodes: - analysis: - project_setup: - override: - - 'true' - tests: - override: - - php-scrutinizer-run - tests: true - coverage: - tests: - override: - - - # xdebug is installed but mode=off; PHPUnit exits 1 when coverage - # is requested without a driver, so enable it explicitly. - command: 'XDEBUG_MODE=coverage vendor/bin/phpunit --coverage-clover=coverage.clover --configuration phpunit.xml' - coverage: - file: 'coverage.clover' - format: 'clover' - -checks: - php: true - -tools: - php_cs_fixer: true diff --git a/CHANGELOG.md b/CHANGELOG.md index 27c95d7..d6ceb01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ All notable changes to this project are documented in this file. - chore: run CI on PHP 8.3, 8.4 and 8.5 (the matrix listed 8.2 twice) - docs: split the README into `docs/` (getting started, configuration, HTTP API, architecture, development) +- chore: drop Scrutinizer (`.scrutinizer.yml`, badges) — GitHub Actions is the only CI gate **Full Changelog**: https://github.com/php-lightning/lnaddress/compare/0.9.0...main diff --git a/README.md b/README.md index 38eb617..2feb688 100644 --- a/README.md +++ b/README.md @@ -4,12 +4,6 @@ GitHub Build Status - - Scrutinizer Code Quality - - - Scrutinizer Code Coverage - Psalm Type-coverage Status diff --git a/docs/development.md b/docs/development.md index 527661e..9fac006 100644 --- a/docs/development.md +++ b/docs/development.md @@ -86,7 +86,7 @@ out-of-memory error inside `resultCache.php`, the cause is a stale result cache 2. **Type Checker** — Psalm (with Shepherd) and PHPStan 3. **Tests** — PHPUnit on PHP 8.3, 8.4 and 8.5, with locked and highest dependencies -Scrutinizer (`.scrutinizer.yml`) collects coverage separately. +Coverage is not collected in CI; run `composer test-coverage` locally for an HTML report. ## Releasing