Fix compression of serialized objects. #119

Merged
merged 2 commits into from Jan 9, 2014

2 participants

@vincentbernat

Due to commit 0f5550e, compressing a
serialized object provided an inappropriate size to s_compress_value()
which will eventually lead to a segfault during compression. Provide the
the previously computed length instead.

@vincentbernat vincentbernat Fix compression of serialized objects.
Due to commit 0f5550e, compressing a
serialized object provided an inappropriate size to `s_compress_value()`
which will eventually lead to a segfault during compression. Provide the
the previously computed length instead.
f794ebe
@vincentbernat

Also, this regression can be catched by tests/experimental/serializer/serializer_php.phpt and tests/experimental/set_comp_below_factor.phpt. Maybe those tests can be migrated out of experimental?

@mkoppanen
php-memcached-dev member

If the tests pass properly it would be good to move them to main directory. Travis CI executes only the tests in the main directory. Can you move the tests, add them to package.xml and submit with this pr? Thanks for your work!

@mkoppanen mkoppanen merged commit 03d2244 into php-memcached-dev:master Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment