Skip to content

Commit

Permalink
drop PHP 7.2
Browse files Browse the repository at this point in the history
  • Loading branch information
eXorus committed Aug 26, 2020
1 parent 73bc8b9 commit f25cfda
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php: [7.2, 7.3, 7.4]
php: [7.3, 7.4]
dependency-version: [prefer-stable]
steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -55,7 +55,7 @@
},
"require-dev": {
"php-coveralls/php-coveralls": "^2.2",
"phpunit/phpunit": "^8.0",
"phpunit/phpunit": "^9.2",
"rregeer/phpunit-coverage-check": "^0.3.1",
"friendsofphp/php-cs-fixer": "^2.16",
"symfony/filesystem": "^5.0",
Expand Down
40 changes: 20 additions & 20 deletions phpunit.xml.dist
@@ -1,22 +1,22 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
bootstrap="vendor/autoload.php"
executionOrder="random"
resolveDependencies="true"
forceCoversAnnotation="true"
beStrictAboutCoversAnnotation="false"
colors="true">

<testsuites>
<testsuite name="PhpMimeMailParser Test Suite">
<directory>tests</directory>
</testsuite>
</testsuites>

<filter>
<whitelist addUncoveredFilesFromWhitelist="true">
<directory suffix=".php">src/</directory>
</whitelist>
</filter>
<phpunit
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
bootstrap="vendor/autoload.php"
executionOrder="random"
resolveDependencies="true"
forceCoversAnnotation="true"
beStrictAboutCoversAnnotation="false"
colors="true"
>
<coverage includeUncoveredFiles="true">
<include>
<directory suffix=".php">src/</directory>
</include>
</coverage>
<testsuites>
<testsuite name="Unit">
<directory>tests</directory>
</testsuite>
</testsuites>
</phpunit>
4 changes: 2 additions & 2 deletions tests/AttachmentTest.php
Expand Up @@ -118,7 +118,7 @@ public function testGeneratingDuplicateSuffixWithoutExtension(): void
$this->assertFileExists($attachDir . 'attach02_3');
$this->assertFileExists($attachDir . 'attach02_4');
$this->assertFileExists($attachDir . 'attach02_5');
$this->assertFileNotExists($attachDir . 'attach02_6');
$this->assertFileDoesNotExist($attachDir . 'attach02_6');
}

public function testGeneratingDuplicateSuffix(): void
Expand All @@ -143,7 +143,7 @@ public function testGeneratingDuplicateSuffix(): void
$this->assertFileExists($attachDir . 'logo_1.jpg');
$this->assertFileExists($attachDir . 'logo_2.jpg');
$this->assertFileExists($attachDir . 'logo_3.jpg');
$this->assertFileNotExists($attachDir . 'logo_4.jpg');
$this->assertFileDoesNotExist($attachDir . 'logo_4.jpg');
}

public function testSavingWithRandomFilenameKeepExtension(): void
Expand Down

0 comments on commit f25cfda

Please sign in to comment.