New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes per #163 #166

Merged
merged 8 commits into from Nov 2, 2017

Conversation

Projects
None yet
4 participants
@dorianfm
Copy link
Contributor

dorianfm commented Oct 24, 2017

This is my proposed addition for a Parser->getInlineParts() method, with Parser->getMessageBody() changed to return ->getInlineParts()[0] or an empty string if no parts match (not so sure about that... may need to return null?)

I've added in tests using the examples provided.

I've also modified the exception thrown by getMessageBody() to specify htmlEmbedded as a valid $type to match the code.

$inline_parts = $Parser->getInlineParts('text');
$this->assertEquals(is_array($inline_parts), true);
$this->assertEquals(count($inline_parts), 2);
$this->assertEquals($inline_parts[0],"First we have a text block, then we insert an image:\r\n\r\n");

This comment has been minimized.

@Nitpick-CI

Nitpick-CI Oct 24, 2017

No space found after comma in function call

$this->assertEquals(is_array($inline_parts), true);
$this->assertEquals(count($inline_parts), 2);
$this->assertEquals($inline_parts[0],"First we have a text block, then we insert an image:\r\n\r\n");
$this->assertEquals($inline_parts[1],"\r\n\r\nThen we have more text\r\n\r\n-- excuse brevity, sent from my phone.");

This comment has been minimized.

@Nitpick-CI

Nitpick-CI Oct 24, 2017

No space found after comma in function call

@eXorus

This comment has been minimized.

Copy link
Member

eXorus commented Oct 27, 2017

I dont't understand why the Travis build don't want to test this PR.

I have "Abuse detected" :)

@dorianfm

This comment has been minimized.

Copy link
Contributor

dorianfm commented Oct 27, 2017

Having just searched I've found this travis-ci/travis-ci#8626 which suggested I needed to grant access to my repo to Travis CI. May work now?

@eXorus eXorus closed this Oct 28, 2017

@eXorus eXorus reopened this Oct 28, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 28, 2017

Coverage Status

Coverage increased (+0.08%) to 97.548% when pulling 47cc8c9 on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 28, 2017

Coverage Status

Coverage increased (+0.08%) to 97.548% when pulling 47cc8c9 on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

eXorus added some commits Oct 31, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.08%) to 97.554% when pulling 00e8f89 on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

eXorus added some commits Oct 31, 2017

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.08%) to 97.554% when pulling 40cb841 on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.08%) to 97.554% when pulling 40cb841 on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.08%) to 97.554% when pulling d86be9b on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.08%) to 97.554% when pulling d86be9b on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.08%) to 97.554% when pulling a3f3a0e on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage increased (+0.08%) to 97.554% when pulling a3f3a0e on theusefularts:master into a3d5b16 on php-mime-mail-parser:master.

@eXorus eXorus merged commit c6884c7 into php-mime-mail-parser:master Nov 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 97.554%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment