fix reloading after emergency mode #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
requested changes
Jul 13, 2018
| @@ -1030,10 +1030,7 @@ public function closeSlaves($graceful = false, $onSlaveClosed = null) | |||
| $onSlaveClosed($slave); | |||
| } | |||
| } | |||
|
|
|||
| $this->filesLastMTime = []; | |||
There was a problem hiding this comment.
Why dont these need be reset?
There was a problem hiding this comment.
That the bug in fact, from ProcessManager POV, if you reset the set of tracked files, they are lost until you restart the ppm process. This is non sense to reset them when closes slaves because it's not related to slaves.
So when a runtime error pop, this is called, and the file watcher is watching ... an empty array and it will never reload
| @@ -944,11 +944,11 @@ protected function closeSlave($slave) | |||
| /** | |||
| * Reload slaves in-place, allowing busy workers to finish what they are doing. | |||
| */ | |||
| public function reloadSlaves() | |||
There was a problem hiding this comment.
comment addressed
|
Great pr- much appreciated! |
This was referenced Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #397, #384