Add dynamic return type for the get_term_by function

[lipemat]

• Return array<int|string> if $output = 'ARRAY_N'.
• Return array<string, int|string> if default or $output = 'ARRAY_A'.
• Return WP_Term if default or $output = 'OBJECT'.

link https://developer.wordpress.org/reference/functions/get_term_by/#parameters

[szepeviktor]

Thank you @lipemat!

It will be public in the next release.

[johnbillion]

Interesting that list<...> turns into array<int, ...> in the tests. I think that's because PHPStan doesn't fully enforce a list yet. Might be worth using the array syntax instead of list? Not sure.

[szepeviktor]

I need 3 independent bug reports to move my dinosaur 🦕 limbs.

[szepeviktor]

<?php

/**
 * @param list<string> $param1
 */
function concat(array $param1): string
{
    return join('', $param1);
}

echo concat([10 => 'do', 20 => 'it!']);

vendor/bin/phpstan analyze -l max list.php

[OK] No errors ✅

[herndlm]

I wasn't sure anymore, but looks like list type is still only enabled via bleeding edge / feature toggle and off by default otherwise. See https://github.com/phpstan/phpstan-src/blob/1.10.35/conf/config.neon#L55

When being off it essentially makes list behave like array<int, T> AFAIK.

[szepeviktor]

@herndlm Thank you!

 ------ -------------------------------------------------------------------------------------------------
  Line   list.php
 ------ -------------------------------------------------------------------------------------------------
  11     Parameter #1 $param1 of function concat expects list<string>, array{10: 'do', 20: 'it!'} given.
         💡 array{10: 'do', 20: 'it!'} is not a list.
 ------ -------------------------------------------------------------------------------------------------