Improve test code #246
Merged
Improve test code #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make fake entity ids random and set current date/time.
Add some helper variables to tests, to cut down the amount of code a bit and make it more readable.
Member
Author
|
@akalongman @MBoretto @jacklul Have you looked at this at all yet? Would like to merge before carrying on with implementations, as there are a lot of code changes. |
Collaborator
|
Hello, just scroll fast so far, in the weekend I plan some time to review them, but if you want go ahead merge! |
Member
Author
|
I'll wait till the weekend, then either you merge or I'll merge next week 😊 Thanks! |
Collaborator
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now allows for local database tests to be configurable. Check the new constants in
phpunit.xml.dist. Just copy it tophpunit.xmland adjust values to your local test environment.A bunch of DocBlock fixes and test renames.
Also makes more use of TestHelpers class to facilitate entity testing.