From dc993a1518819b507ca536962652508aa414861b Mon Sep 17 00:00:00 2001 From: bocharsky-bw Date: Fri, 26 Mar 2021 20:57:11 +0200 Subject: [PATCH 1/5] Typecast ->request->get() value to string --- Controller/SymfonyProfilerController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Controller/SymfonyProfilerController.php b/Controller/SymfonyProfilerController.php index 306cfe2e..7530e279 100644 --- a/Controller/SymfonyProfilerController.php +++ b/Controller/SymfonyProfilerController.php @@ -60,7 +60,7 @@ public function editAction(Request $request, string $token): Response } //Assert: This is a POST request - $message->setTranslation($request->request->get('translation')); + $message->setTranslation((string)$request->request->get('translation')); $this->storage->update($message->convertToMessage()); return new Response($message->getTranslation()); From 911c109a6257f2c8c65b7713dc89234a4219b21f Mon Sep 17 00:00:00 2001 From: bocharsky-bw Date: Fri, 26 Mar 2021 21:03:34 +0200 Subject: [PATCH 2/5] Fix PHP CS Fixer issue --- Controller/SymfonyProfilerController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Controller/SymfonyProfilerController.php b/Controller/SymfonyProfilerController.php index 7530e279..301330e7 100644 --- a/Controller/SymfonyProfilerController.php +++ b/Controller/SymfonyProfilerController.php @@ -60,7 +60,7 @@ public function editAction(Request $request, string $token): Response } //Assert: This is a POST request - $message->setTranslation((string)$request->request->get('translation')); + $message->setTranslation((string) $request->request->get('translation')); $this->storage->update($message->convertToMessage()); return new Response($message->getTranslation()); From 9162bc89cd8f863e9e5715e39f4ac8b0181f30cc Mon Sep 17 00:00:00 2001 From: bocharsky-bw Date: Fri, 26 Mar 2021 21:17:51 +0200 Subject: [PATCH 3/5] Fix other psalm issues --- Controller/SymfonyProfilerController.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Controller/SymfonyProfilerController.php b/Controller/SymfonyProfilerController.php index 301330e7..35803f46 100644 --- a/Controller/SymfonyProfilerController.php +++ b/Controller/SymfonyProfilerController.php @@ -125,7 +125,7 @@ private function getMessage(Request $request, string $token): SfProfilerMessage { $this->profiler->disable(); - $messageId = $request->request->get('message_id', $request->query->get('message_id')); + $messageId = (string) $request->request->get('message_id', $request->query->get('message_id')); $collectorMessages = $this->getMessages($token); @@ -154,8 +154,9 @@ protected function getSelectedMessages(Request $request, string $token): array { $this->profiler->disable(); - $selected = $request->request->get('selected'); - if (!$selected || 0 == \count($selected)) { + /** @var string[] $selected */ + $selected = (array)$request->request->get('selected'); + if (0 === \count($selected)) { return []; } From 6d8382ad05755aa80d93dfc55c327f00abe62f69 Mon Sep 17 00:00:00 2001 From: bocharsky-bw Date: Fri, 26 Mar 2021 21:20:50 +0200 Subject: [PATCH 4/5] Fix PHP CS Fixer issues one more time --- Controller/SymfonyProfilerController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Controller/SymfonyProfilerController.php b/Controller/SymfonyProfilerController.php index 35803f46..3b4f7921 100644 --- a/Controller/SymfonyProfilerController.php +++ b/Controller/SymfonyProfilerController.php @@ -155,7 +155,7 @@ protected function getSelectedMessages(Request $request, string $token): array $this->profiler->disable(); /** @var string[] $selected */ - $selected = (array)$request->request->get('selected'); + $selected = (array) $request->request->get('selected'); if (0 === \count($selected)) { return []; } From 54e1254f18b9a13ff4b55ee1520a38811b390496 Mon Sep 17 00:00:00 2001 From: bocharsky-bw Date: Fri, 26 Mar 2021 21:31:09 +0200 Subject: [PATCH 5/5] Try to fix PhpStan issue --- phpstan-baseline.neon | 5 ----- 1 file changed, 5 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 88381d01..30f38771 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -25,11 +25,6 @@ parameters: count: 1 path: Command/StatusCommand.php - - - message: "#^Call to an undefined static method Symfony\\\\Component\\\\Intl\\\\Intl\\:\\:getLocaleBundle\\(\\)\\.$#" - count: 1 - path: Controller/WebUIController.php - - message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\TreeBuilder\\:\\:root\\(\\)\\.$#" count: 1