Add functional tests for findElement for child elements

Author: OndraM

tests/functional/RemoteWebDriverFindElementTest.php

@@ -24,7 +24,7 @@
  */
 class RemoteWebDriverFindElementTest extends WebDriverTestCase
 {
-    public function testShouldThrowExceptionOfElementCannotBeFound()
+    public function testShouldThrowExceptionIfElementCannotBeFound()
     {
         $this->driver->get($this->getTestPageUrl('index.html'));
 
@@ -58,7 +58,7 @@ public function testShouldFindMultipleElements()
         $elements = $this->driver->findElements(WebDriverBy::cssSelector('ul > li'));
 
         $this->assertInternalType('array', $elements);
-        $this->assertCount(3, $elements);
+        $this->assertCount(5, $elements);
         $this->assertContainsOnlyInstancesOf(RemoteWebElement::class, $elements);
     }
 }

tests/functional/RemoteWebElementTest.php

@@ -15,6 +15,9 @@
 
 namespace Facebook\WebDriver;
 
+use Facebook\WebDriver\Exception\NoSuchElementException;
+use Facebook\WebDriver\Remote\RemoteWebElement;
+
 /**
  * @coversDefaultClass Facebook\WebDriver\Remote\RemoteWebElement
  */
@@ -282,4 +285,53 @@ public function testShouldCompareEqualsElement()
         $this->assertFalse($firstElement->equals($differentElement));
         $this->assertFalse($differentElement->equals($againTheFirstElement));
     }
+
+    /**
+     * @covers ::findElement
+     */
+    public function testShouldThrowExceptionIfChildElementCannotBeFound()
+    {
+        $this->driver->get($this->getTestPageUrl('index.html'));
+        $element = $this->driver->findElement(WebDriverBy::cssSelector('ul.list'));
+
+        $this->expectException(NoSuchElementException::class);
+        $element->findElement(WebDriverBy::id('not_existing'));
+    }
+
+    public function testShouldFindChildElementIfExistsOnAPage()
+    {
+        $this->driver->get($this->getTestPageUrl('index.html'));
+        $element = $this->driver->findElement(WebDriverBy::cssSelector('ul.list'));
+
+        $childElement = $element->findElement(WebDriverBy::cssSelector('li'));
+
+        $this->assertInstanceOf(RemoteWebElement::class, $childElement);
+        $this->assertSame('li', $childElement->getTagName());
+        $this->assertSame('First', $childElement->getText());
+    }
+
+    public function testShouldReturnEmptyArrayIfChildElementsCannotBeFound()
+    {
+        $this->driver->get($this->getTestPageUrl('index.html'));
+        $element = $this->driver->findElement(WebDriverBy::cssSelector('ul.list'));
+
+        $childElements = $element->findElements(WebDriverBy::cssSelector('not_existing'));
+
+        $this->assertInternalType('array', $childElements);
+        $this->assertCount(0, $childElements);
+    }
+
+    public function testShouldFindMultipleChildElements()
+    {
+        $this->driver->get($this->getTestPageUrl('index.html'));
+        $element = $this->driver->findElement(WebDriverBy::cssSelector('ul.list'));
+
+        $allElements = $this->driver->findElements(WebDriverBy::cssSelector('li'));
+        $childElements = $element->findElements(WebDriverBy::cssSelector('li'));
+
+        $this->assertInternalType('array', $childElements);
+        $this->assertCount(5, $allElements); // there should be 5 <li> elements on page
+        $this->assertCount(3, $childElements); // but we should find only subelements of one <ul>
+        $this->assertContainsOnlyInstancesOf(RemoteWebElement::class, $childElements);
+    }
 }

tests/functional/web/index.html

@@ -30,6 +30,11 @@ <h1 id='welcome'>Welcome to the facebook/php-webdriver testing page.</h1>
     <li>Third</li>
 </ul>
 
+<ul class="other-list">
+    <li>Foo</li>
+    <li>Bar</li>
+</ul>
+
 <p id="text-simple" role="note" style="height: 5em; border: 1px solid black;">Foo bar text</p>
 <p id="text-with-spaces">
     Multiple       spaces   are

tests/unit/Remote/RemoteWebElementTest.php

@@ -0,0 +1,36 @@
+<?php
+// Copyright 2004-present Facebook. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+namespace Facebook\WebDriver\Remote;
+
+/**
+ * Unit part of RemoteWebDriver tests. Ie. tests for behavior which do not interact with the real remote server.
+ *
+ * @coversDefaultClass Facebook\WebDriver\Remote\RemoteWebElement
+ */
+class RemoteWebElementTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @covers ::__construct
+     * @covers ::getId
+     */
+    public function testShouldConstructNewInstance()
+    {
+        $executeMethod = $this->createMock(RemoteExecuteMethod::class);
+        $element = new RemoteWebElement($executeMethod, 333);
+
+        $this->assertSame(333, $element->getID());
+    }
+}