Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always put __construct first in class method list #799

Closed
othercorey opened this issue Jul 18, 2021 · 2 comments
Closed

Always put __construct first in class method list #799

othercorey opened this issue Jul 18, 2021 · 2 comments

Comments

@othercorey
Copy link
Contributor

Is it possible to sort the class methods where __construct is first? It looks very odd when it's shorted alphabetically without the __.

Example:

https://www.php.net/manual/en/class.recursiveiteratoriterator.php

public beginChildren(): void
public beginIteration(): void
public callGetChildren(): RecursiveIterator
public callHasChildren(): bool
public __construct(Traversable $iterator, int $mode = RecursiveIteratorIterator::LEAVES_ONLY, int $flags = 0)
public current(): mixed
@cmb69
Copy link
Member

cmb69 commented Jul 18, 2021

That requires the constructor to be marked up with <constructorsynopsis> instead of <methodsynopsis>. PR #624 would fix this for RecursiveIteratorIterator (and likely some others).

@othercorey
Copy link
Contributor Author

Thanks for the explanation.

I don't want to request someone do a lot of work, but its it difficult to verify any construct.xml contains the constructorsynopsis version?

It's just patch it as you find it then so be it. Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants