Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snmp: add SHA256 and SHA512 for security protocol in 8.1 #1727

Merged
merged 4 commits into from Jul 29, 2022
Merged

snmp: add SHA256 and SHA512 for security protocol in 8.1 #1727

merged 4 commits into from Jul 29, 2022

Conversation

remicollet
Copy link
Contributor

cmb69
cmb69 reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Do you think it's worth mentioning, that SHA256 and SHA512 need to be supported by the underlying libsnmp?

FWIW, we should define XML entities for this repetitive stuff, but it's okay for now to repeat.

reference/snmp/functions/snmp3-get.xml Outdated Show resolved Hide resolved
reference/snmp/functions/snmp3-get.xml Outdated Show resolved Hide resolved
reference/snmp/functions/snmp3-getnext.xml Outdated Show resolved Hide resolved
reference/snmp/functions/snmp3-real-walk.xml Outdated Show resolved Hide resolved
reference/snmp/functions/snmp3-walk.xml Outdated Show resolved Hide resolved
reference/snmp/functions/snmp3-getnext.xml Outdated Show resolved Hide resolved
reference/snmp/functions/snmp3-real-walk.xml Outdated Show resolved Hide resolved
reference/snmp/functions/snmp3-walk.xml Outdated Show resolved Hide resolved
@remicollet @cmb69
Apply suggestions from code review
8fb0e84 
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@remicollet
Copy link
Contributor Author

Thank you! Do you think it's worth mentioning, that SHA256 and SHA512 need to be supported by the underlying libsnmp?

Probably no, in all case the error message about supported algo will be displayed if needed
PHP Fatal error: Uncaught ValueError: Authentication protocol must be "SHA" or "SHA256" or "SHA512" or "MD5" in Command line code:1

@remicollet
Copy link
Contributor Author

I fixed missing closing > in your suggestions
And added " when supported by libnetsnmp"

@remicollet remicollet requested a review from cmb69 July 29, 2022 15:45
cmb69
cmb69 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@remicollet remicollet merged commit 1051736 into php:master Jul 29, 2022
2 checks passed
@remicollet remicollet deleted the issue-snmp-sha branch July 29, 2022 15:50
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
@remicollet @cmb69 @tiffany-taylor
snmp: add SHA256 and SHA512 for security protocol in 8.1 (php#1727)
da8949a 
* snmp: add SHA256 and SHA512 for security protocol in 8.1

* Apply suggestions from code review

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
claudepache pushed a commit to claudepache/php-doc-en that referenced this pull request Jun 1, 2023
@remicollet @cmb69 @claudepache
snmp: add SHA256 and SHA512 for security protocol in 8.1 (php#1727)
114aa6f 
* snmp: add SHA256 and SHA512 for security protocol in 8.1

* Apply suggestions from code review

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@remicollet @cmb69