Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note that all visibilities of trait abstract methods are supported. #476

Closed
wants to merge 2 commits into from
Closed

Note that all visibilities of trait abstract methods are supported. #476

wants to merge 2 commits into from

Conversation

Crell
Copy link
Contributor

@Crell Crell commented Mar 4, 2021 •
edited
Loading

The docs didn't specify before, so I just clarified that it does now work on all of them.

@cmb69
Copy link
Member

cmb69 commented Mar 8, 2021

The word "now" appears to be important here. Please clarify that private is supported only as of PHP 8.0.0.

@Crell
Copy link
Contributor Author

Crell commented Mar 8, 2021

Done.

cmb69
cmb69 approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@php-pulls php-pulls closed this in 77a77db Mar 10, 2021
@Crell Crell deleted the trait-private-method branch April 7, 2021 23:53
@Girgias Girgias mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crell @cmb69