From 43b82d2534dfbb3266e15ed1c0e1c5b2bd5a8880 Mon Sep 17 00:00:00 2001
From: thinkverse <hallberg.kim@gmail.com>
Date: Thu, 29 Apr 2021 16:23:36 +0200
Subject: [PATCH 1/6] Add TypeError to changelog

---
 reference/strings/functions/explode.xml | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/reference/strings/functions/explode.xml b/reference/strings/functions/explode.xml
index 9040e00f3689..64c21549837b 100644
--- a/reference/strings/functions/explode.xml
+++ b/reference/strings/functions/explode.xml
@@ -190,6 +190,29 @@ Array
   </para>
  </refsect1>
 
+<refsect1 role="changelog">
+ &reftitle.changelog;
+ <informaltable>
+  <tgroup cols="2">
+   <thead>
+    <row>
+     <entry>&Version;</entry>
+     <entry>&Description;</entry>
+    </row>
+   </thead>
+   <tbody>
+    <row>
+     <entry>8.0.0</entry>
+     <entry>
+      <function>explode</function> will now throw <classname>TypeError</classname> 
+      when <parameter>separator</parameter> parameter is given an empty argument.
+     </entry>
+    </row>
+   </tbody>
+  </tgroup>
+ </informaltable>
+</refsect1>
+
  <refsect1 role="notes">
   &reftitle.notes;
   &note.bin-safe;

From db23d09e4b8bc6ba8beb9d026add21de5e1dd682 Mon Sep 17 00:00:00 2001
From: thinkverse <hallberg.kim@gmail.com>
Date: Thu, 29 Apr 2021 16:27:14 +0200
Subject: [PATCH 2/6] Update changelog description

---
 reference/strings/functions/explode.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/reference/strings/functions/explode.xml b/reference/strings/functions/explode.xml
index 64c21549837b..5bc7a0c17984 100644
--- a/reference/strings/functions/explode.xml
+++ b/reference/strings/functions/explode.xml
@@ -205,7 +205,7 @@ Array
      <entry>8.0.0</entry>
      <entry>
       <function>explode</function> will now throw <classname>TypeError</classname> 
-      when <parameter>separator</parameter> parameter is given an empty argument.
+      when <parameter>separator</parameter> parameter is given an empty string ("").
      </entry>
     </row>
    </tbody>

From 67029e8bcf1a73c9c8d191219ed860cba86641d3 Mon Sep 17 00:00:00 2001
From: thinkverse <hallberg.kim@gmail.com>
Date: Thu, 29 Apr 2021 16:39:32 +0200
Subject: [PATCH 3/6] Add note about seperator values at start of end of string

---
 reference/strings/functions/explode.xml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/reference/strings/functions/explode.xml b/reference/strings/functions/explode.xml
index 5bc7a0c17984..ca9f97764f56 100644
--- a/reference/strings/functions/explode.xml
+++ b/reference/strings/functions/explode.xml
@@ -84,7 +84,10 @@
    contained in <parameter>string</parameter> and a negative
    <parameter>limit</parameter> is used, then an empty <type>array</type> will be
    returned, otherwise an <type>array</type> containing
-   <parameter>string</parameter> will be returned.
+   <parameter>string</parameter> will be returned. If <parameter>separator</parameter> 
+   values appear at the start or end of <parameter>string</parameter>, said values 
+   will be added as an empty <type>array</type> value either in the first or last 
+   position of the returned <type>array</type> respectively.
   </para>
  </refsect1>
 

From 8c094010869502a7e85c224580a71127864cdb8a Mon Sep 17 00:00:00 2001
From: thinkverse <hallberg.kim@gmail.com>
Date: Thu, 29 Apr 2021 17:03:16 +0200
Subject: [PATCH 4/6] Change position of changelog

---
 reference/strings/functions/explode.xml | 46 ++++++++++++-------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/reference/strings/functions/explode.xml b/reference/strings/functions/explode.xml
index ca9f97764f56..6939036935a1 100644
--- a/reference/strings/functions/explode.xml
+++ b/reference/strings/functions/explode.xml
@@ -91,6 +91,29 @@
   </para>
  </refsect1>
 
+ <refsect1 role="changelog">
+  &reftitle.changelog;
+  <informaltable>
+    <tgroup cols="2">
+      <thead>
+       <row>
+        <entry>&Version;</entry>
+        <entry>&Description;</entry>
+       </row>
+      </thead>
+      <tbody>
+       <row>
+        <entry>8.0.0</entry>
+        <entry>
+          <function>explode</function> will now throw <classname>TypeError</classname> 
+          when <parameter>separator</parameter> parameter is given an empty string ("").
+        </entry>
+       </row>
+      </tbody>
+    </tgroup>
+  </informaltable>
+ </refsect1>
+
  <refsect1 role="examples">
   &reftitle.examples;
   <para>
@@ -193,29 +216,6 @@ Array
   </para>
  </refsect1>
 
-<refsect1 role="changelog">
- &reftitle.changelog;
- <informaltable>
-  <tgroup cols="2">
-   <thead>
-    <row>
-     <entry>&Version;</entry>
-     <entry>&Description;</entry>
-    </row>
-   </thead>
-   <tbody>
-    <row>
-     <entry>8.0.0</entry>
-     <entry>
-      <function>explode</function> will now throw <classname>TypeError</classname> 
-      when <parameter>separator</parameter> parameter is given an empty string ("").
-     </entry>
-    </row>
-   </tbody>
-  </tgroup>
- </informaltable>
-</refsect1>
-
  <refsect1 role="notes">
   &reftitle.notes;
   &note.bin-safe;

From 1881e3db8ea2f20815ad75d9b630e7b15f4805de Mon Sep 17 00:00:00 2001
From: thinkverse <hallberg.kim@gmail.com>
Date: Thu, 29 Apr 2021 17:10:57 +0200
Subject: [PATCH 5/6] Add fold marker comments

---
 reference/strings/functions/explode.xml | 28 ++++++++++++-------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/reference/strings/functions/explode.xml b/reference/strings/functions/explode.xml
index 6939036935a1..a07041f20d10 100644
--- a/reference/strings/functions/explode.xml
+++ b/reference/strings/functions/explode.xml
@@ -6,7 +6,7 @@
   <refpurpose>Split a string by a string</refpurpose>
  </refnamediv>
  
- <refsect1 role="description">
+ <refsect1 role="description"><!-- {{{ -->
   &reftitle.description;
   <methodsynopsis>
    <type>array</type><methodname>explode</methodname>
@@ -19,9 +19,9 @@
    <parameter>string</parameter> formed by splitting it on
    boundaries formed by the string <parameter>separator</parameter>.
   </para>
- </refsect1>
+ </refsect1><!-- }}} -->
 
- <refsect1 role="parameters">
+ <refsect1 role="parameters"><!-- {{{ -->
   &reftitle.parameters;
   <para>
    <variablelist>
@@ -68,9 +68,9 @@
     <parameter>string</parameter> argument.
    </para>
   </note>
- </refsect1>
+ </refsect1><!-- }}} -->
 
- <refsect1 role="returnvalues">
+ <refsect1 role="returnvalues"><!-- {{{ -->
   &reftitle.returnvalues;
   <para>
    Returns an <type>array</type> of <type>string</type>s
@@ -89,9 +89,9 @@
    will be added as an empty <type>array</type> value either in the first or last 
    position of the returned <type>array</type> respectively.
   </para>
- </refsect1>
+ </refsect1><!-- }}} -->
 
- <refsect1 role="changelog">
+ <refsect1 role="changelog"><!-- {{{ -->
   &reftitle.changelog;
   <informaltable>
     <tgroup cols="2">
@@ -112,9 +112,9 @@
       </tbody>
     </tgroup>
   </informaltable>
- </refsect1>
+ </refsect1><!-- }}} -->
 
- <refsect1 role="examples">
+ <refsect1 role="examples"><!-- {{{ -->
   &reftitle.examples;
   <para>
    <example>
@@ -214,14 +214,14 @@ Array
     </screen>
    </example>
   </para>
- </refsect1>
+ </refsect1><!-- }}} -->
 
- <refsect1 role="notes">
+ <refsect1 role="notes"><!-- {{{ -->
   &reftitle.notes;
   &note.bin-safe;
- </refsect1>
+ </refsect1><!-- }}} -->
 
- <refsect1 role="seealso">
+ <refsect1 role="seealso"><!-- {{{ -->
   &reftitle.seealso;
   <para>
    <simplelist>
@@ -233,7 +233,7 @@ Array
     <member><function>implode</function></member>
    </simplelist>
   </para>
- </refsect1>
+ </refsect1><!-- }}} -->
 
 </refentry>
 <!-- Keep this comment at the end of the file

From e4fbc50adce010b1afdff4d87c858ad324f17afb Mon Sep 17 00:00:00 2001
From: thinkverse <hallberg.kim@gmail.com>
Date: Thu, 29 Apr 2021 17:52:53 +0200
Subject: [PATCH 6/6] Revert "Add fold marker comments"

This reverts commit 1881e3db8ea2f20815ad75d9b630e7b15f4805de.
---
 reference/strings/functions/explode.xml | 28 ++++++++++++-------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/reference/strings/functions/explode.xml b/reference/strings/functions/explode.xml
index a07041f20d10..6939036935a1 100644
--- a/reference/strings/functions/explode.xml
+++ b/reference/strings/functions/explode.xml
@@ -6,7 +6,7 @@
   <refpurpose>Split a string by a string</refpurpose>
  </refnamediv>
  
- <refsect1 role="description"><!-- {{{ -->
+ <refsect1 role="description">
   &reftitle.description;
   <methodsynopsis>
    <type>array</type><methodname>explode</methodname>
@@ -19,9 +19,9 @@
    <parameter>string</parameter> formed by splitting it on
    boundaries formed by the string <parameter>separator</parameter>.
   </para>
- </refsect1><!-- }}} -->
+ </refsect1>
 
- <refsect1 role="parameters"><!-- {{{ -->
+ <refsect1 role="parameters">
   &reftitle.parameters;
   <para>
    <variablelist>
@@ -68,9 +68,9 @@
     <parameter>string</parameter> argument.
    </para>
   </note>
- </refsect1><!-- }}} -->
+ </refsect1>
 
- <refsect1 role="returnvalues"><!-- {{{ -->
+ <refsect1 role="returnvalues">
   &reftitle.returnvalues;
   <para>
    Returns an <type>array</type> of <type>string</type>s
@@ -89,9 +89,9 @@
    will be added as an empty <type>array</type> value either in the first or last 
    position of the returned <type>array</type> respectively.
   </para>
- </refsect1><!-- }}} -->
+ </refsect1>
 
- <refsect1 role="changelog"><!-- {{{ -->
+ <refsect1 role="changelog">
   &reftitle.changelog;
   <informaltable>
     <tgroup cols="2">
@@ -112,9 +112,9 @@
       </tbody>
     </tgroup>
   </informaltable>
- </refsect1><!-- }}} -->
+ </refsect1>
 
- <refsect1 role="examples"><!-- {{{ -->
+ <refsect1 role="examples">
   &reftitle.examples;
   <para>
    <example>
@@ -214,14 +214,14 @@ Array
     </screen>
    </example>
   </para>
- </refsect1><!-- }}} -->
+ </refsect1>
 
- <refsect1 role="notes"><!-- {{{ -->
+ <refsect1 role="notes">
   &reftitle.notes;
   &note.bin-safe;
- </refsect1><!-- }}} -->
+ </refsect1>
 
- <refsect1 role="seealso"><!-- {{{ -->
+ <refsect1 role="seealso">
   &reftitle.seealso;
   <para>
    <simplelist>
@@ -233,7 +233,7 @@ Array
     <member><function>implode</function></member>
    </simplelist>
   </para>
- </refsect1><!-- }}} -->
+ </refsect1>
 
 </refentry>
 <!-- Keep this comment at the end of the file