Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug #77856 (xdiff_string_patch() no $error returned). #4

Open
wants to merge 1 commit into
base: master
from

Conversation

@ranvis
Copy link

commented Apr 5, 2019

The fourth parameter of xdiff_string_patch() $error should return failed hunks of the patch, but nothing is returned.

@ranvis ranvis force-pushed the ranvis:bug77856 branch from 6b0f0ae to c4e1b5a Apr 5, 2019

@ranvis

This comment has been minimized.

Copy link
Author

commented Apr 5, 2019

Added the same fix for xdiff_string_merge3().

@peter279k

This comment has been minimized.

Copy link

commented May 5, 2019

It looks good, but it lacks the CI work.

Is it possible to have the Travis CI to test this automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.