Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

killed warning + added reminder

  • Loading branch information...
commit a04805ce889fd24120da713a65d982183626ef67 1 parent 337bcc7
Thies C. Arntzen authored
Showing with 3 additions and 1 deletion.
  1. +2 −0  TODO
  2. +1 −1  ext/xml/xml.c
View
2  TODO
@@ -3,6 +3,8 @@ parenthesis means that person has taken on this project.
global
------
+ * make sure that all ZTS globals get destructed. Most ts_allocate_id()
+ calls should have a dtor entry.
* activate all extensions by default that don't rely on external
dependices. (eg ftp)
* --enable-all in configure. (--enable-shared=max ...)
View
2  ext/xml/xml.c
@@ -164,7 +164,7 @@ PHP_MINIT_FUNCTION(xml)
le_xml_parser = register_list_destructors(xml_parser_dtor, NULL);
#ifdef ZTS
- xml_globals_id = ts_allocate_id(sizeof(php_xml_globals), php_xml_init_globals, NULL);
+ xml_globals_id = ts_allocate_id(sizeof(php_xml_globals), (ts_allocate_ctor) php_xml_init_globals, NULL);
#else
XML(default_encoding) = "ISO-8859-1";
#endif
Please sign in to comment.
Something went wrong with that request. Please try again.