Permalink
Browse files

Fix English and improve by Stas. Thanks :)

  • Loading branch information...
Yasuo Ohgaki authored and smalyshev committed Jan 26, 2014
1 parent f496aac commit d65ddb633d4fef54bd9715c4a159d8a7462eed2d
Showing with 13 additions and 9 deletions.
  1. +5 −4 CODING_STANDARDS
  2. +1 −1 README.EXT_SKEL
  3. +7 −4 README.SUBMITTING_PATCH
View
@@ -166,9 +166,10 @@ User Functions/Methods Naming Conventions
Internal Function Naming Convensions
----------------------
-1. Exposed module API must be named 'php_modulename_function()' to avoid
- symbol collision. They should be in lowercase, with words underscore
- delimited. Exposed API must be defined in 'php_modulename.h'.
+1. Functions that are part of the external API should be named
+ 'php_modulename_function()' to avoid symbol collision. They should be in
+ lowercase, with words underscore delimited. Exposed API must be defined
+ in 'php_modulename.h'.
PHPAPI char *php_session_create_id(PS_CREATE_SID_ARGS);
@@ -179,7 +180,7 @@ Internal Function Naming Convensions
2. Main module source file must be named 'modulename.c'.
-3. Header file that are used by other sources must be named 'php_modulename.h'.
+3. Header file that is used by other sources must be named 'php_modulename.h'.
Syntax and indentation
View
@@ -91,7 +91,7 @@ FORMAT OF FUNCTION DEFINITIONS FILE
module_name_function(int arg1, int arg2 [, int arg3 [, int arg4]])
- Arguments arg1 and arg2 is required.
+ Arguments arg1 and arg2 are required.
Arguments arg3 and arg4 are optional.
If possible, the function definition should also contain it's return type
View
@@ -50,13 +50,16 @@ Please make the mail subject prefix "[PATCH]". If attaching a patch,
ensure it has a file extension of ".txt". This is because only MIME
attachments of type 'text/*' are accepted.
-Preferred way to propose PHP patch is sending pull request from github.
+The preferred way to propose PHP patch is sending pull request from
+github.
https://github.com/php/php-src
-Fork official PHP repository and send pull request. It will be notified
-to pull request mailing list. You can add pull requests to
-http://bugs.php.net/ reports also.
+Fork the official PHP repository and send a pull request. A
+notification will be sent to the pull request mailing list. Sending a
+note to PHP Internals list (internals@lists.php.net) may help getting
+more feedback and quicker turnaround. You can also add pull requests
+to bug reports at http://bugs.php.net/.
PHP Documentation Patches

0 comments on commit d65ddb6

Please sign in to comment.