Skip to content
Permalink
Browse files

Fix memory leak in TLS matches_san_list

  • Loading branch information
kelunik authored and nikic committed Aug 3, 2018
1 parent fcd6f2d commit fea9f93166a31760679101269aee2326ee8185e9
Showing with 6 additions and 0 deletions.
  1. +6 −0 ext/openssl/xp_ssl.c
@@ -426,6 +426,8 @@ static zend_bool php_openssl_matches_san_list(X509 *peer, const char *subject_na

if (php_openssl_matches_wildcard_name(subject_name, (const char *)cert_name)) {
OPENSSL_free(cert_name);
sk_GENERAL_NAME_pop_free(alt_names, GENERAL_NAME_free);

return 1;
}
OPENSSL_free(cert_name);
@@ -438,6 +440,8 @@ static zend_bool php_openssl_matches_san_list(X509 *peer, const char *subject_na
san->d.iPAddress->data[3]
);
if (strcasecmp(subject_name, (const char*)ipbuffer) == 0) {
sk_GENERAL_NAME_pop_free(alt_names, GENERAL_NAME_free);

return 1;
}
}
@@ -448,6 +452,8 @@ static zend_bool php_openssl_matches_san_list(X509 *peer, const char *subject_na
}
}

sk_GENERAL_NAME_pop_free(alt_names, GENERAL_NAME_free);

return 0;
}
/* }}} */

0 comments on commit fea9f93

Please sign in to comment.
You can’t perform that action at this time.