Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intl TZData version not displayed anymore #11071

Closed
remicollet opened this issue Apr 14, 2023 · 1 comment
Closed

intl TZData version not displayed anymore #11071

remicollet opened this issue Apr 14, 2023 · 1 comment

Comments

@remicollet
Copy link
Member

Description

Since 8.0, related to ea86865

Before:

$ php --ri intl

intl

Internationalization support => enabled
ICU version => 72.1
ICU Data version => 72.1
ICU TZData version => 2022e
ICU Unicode version => 15.0

After:

$ php --ri intl

intl

Internationalization support => enabled
ICU version => 72.1
ICU Data version => 72.1
ICU Unicode version => 15.0

UCONFIG_NO_FORMATTING is always defined, as uconfig have

#ifndef UCONFIG_NO_FORMATTING
#   define UCONFIG_NO_FORMATTING 0
#endif

@Girgias can you please have a look, as you are the author of ea86865

PHP Version

PHP 8.0

Operating System

No response

@remicollet
Copy link
Member Author

A simple revert of ea86865
fixes this issue, I was unable to reproduce the case where this macro is not defined.

remicollet added a commit to remicollet/php-src that referenced this issue Apr 14, 2023
remicollet added a commit that referenced this issue Apr 18, 2023
* PHP-8.1:
  Fix GH-11071: Revert "Fix [-Wundef] warning in INTL extension"
remicollet added a commit that referenced this issue Apr 18, 2023
* PHP-8.2:
  Fix GH-11071: Revert "Fix [-Wundef] warning in INTL extension"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@remicollet and others