Compiling php 8.4.10 with --with-tidy flag failed

[InputOutputZ]

Description

Hi there,

I just cloned php 8.4.10 and tried to compile it and it failed, it throws:-
/tidy/tidy.dep -MT ext/tidy/tidy.lo
/root/php-src/ext/tidy/tidy.c: In function ‘_php_tidy_set_tidy_opt’:
/root/php-src/ext/tidy/tidy.c:238:40: error: ‘TidyInternalCategory’ undeclared (first use in this function)
238 | if (tidyOptGetCategory(opt) == TidyInternalCategory) {
| ^~~~~~~~~~~~~~~~~~~~
/root/php-src/ext/tidy/tidy.c:238:40: note: each undeclared identifier is reported only once for each function it appears in
make: *** [Makefile:2868: ext/tidy/tidy.lo] Error 1
make: *** Waiting for unfinished jobs....

I can confirm this issue doesn't exist at least in php 8.4.8, 8.4.7, 8.4.6 as I was able to compile php with same configuration.

Any recommendation?

With thanks.

Zak.

PHP Version

PHP 8.4.10

Operating System

Centos 7

[devnexen]

Hi @InputOutputZ just rapidly, can you tell which of the following is uncommented in main/php_config.h ?

• HAVE_TIDY_H
• HAVE_TIDYP_H

[InputOutputZ]

Hi @InputOutputZ just rapidly, can you tell which of the following is uncommented in main/php_config.h ?

• HAVE_TIDY_H
• HAVE_TIDYP_H

Hi @devnexen, here is the content of php_config.h

/* Define to 1 if you have the <tidyp.h> header file. */
/* #undef HAVE_TIDYP_H */
.....
/* Define to 1 if you have the <tidy.h> header file. */
#define HAVE_TIDY_H 1

Therefore, I think it's HAVE_TIDY_H the one that is not commented?

[remicollet]

Centos 7

Are you aware this distribution is out of support for >1 year ?
Everything is terribly old (and unsecure) there

[devnexen]

Ok maybe in older versions some calls were spread through different headers ? Just assumption, I do not know tidy* that much ; I may have a look later unless someone beats me to it.

[InputOutputZ]

Centos 7

Are you aware this distribution is out of support for >1 year ? Everything is terribly old (and unsecure) there

I'm aware, and thanks for raising this point.

[InputOutputZ]

Ok maybe in older versions some calls were spread through different headers ? Just assumption, I do not know tidy* that much ; I may have a look later unless someone beats me to it.

I just upgraded libtidy and this has fixed the issue.

Because of this deprecation change which was pushed in 2017 yet fully enforced 2025.
htacg/tidy-html5@79f0d57
https://www.php.net/ChangeLog-8.php#8.4.10

In case anyone needs idea on how to upgrade libtidy, you can using following instruction:-
git clone https://github.com/htacg/tidy-html5.git && cd tidy-html5/ && git checkout 5.8.0 && cd build/cmake && cmake ../.. -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr && make && make install

Anyhow, thanks everyone for your assistance.

[arjendekorte]

The problem here is that in libtidy the tidyOptGetCategory was added in version 5.4.0, but TidyInternalCategory was only added in 5.6.0. So it is possible that HAVE_TIDYOPTGETCATEGORY is defined, but compilation fails because the library doesn't have TidyInternalCategory. It would have been better to check for the latter.

[devnexen]

Ok will have a look shortly.

[arjendekorte]

See #19498