Review and backport GH-19870

[iluuu1994]

Description

Link for convenience: GH-19870

This was merged early to 1. solve nightly and 2. prevent 8.5 from having a trivial use-of-uninitialized-value in the test suite. Jakub didn't have time to review. This patch should be backported as it also affects 8.3 (and lower) with the auto_globals_jit=0 ini setting.

PHP Version

-

Operating System

No response

[bukka]

@iluuu1994 I just went through the logic couple of times as it's not exactly understandable (I still don't get why it was named armed but naming is probably hard.. :)). The issue that I was fixing before was actually about something a bit different even though I was looking to autoglobals back hen. Anyway I still needed to properly refresh how autoglobals registration works. I can't find any issue in it and the new logic looks good to me so I think it can be backported.

[bukka]

I mean logic in this commit (with fixed test of course): 8b51bca

[iluuu1994]

Thanks for having a look. I will backport the fix then.

I still don't get why it was named armed but naming is probably hard..

It's not you, it's a strange variable name. I'm guessing it signals whether the callback is "armed" like a loaded weapon, i.e. whether it will be triggered when accessed.

[bukka]

I'm guessing it signals whether the callback is "armed" like a loaded weapon, i.e. whether it will be triggered when accessed.

Ah, that might be it... 😄