Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug #69174 (leaks when unused inner class use traits precedence) #1138

Closed
wants to merge 3 commits into from

Conversation

2 participants
@reeze
Copy link
Contributor

commented Mar 3, 2015

This was uncovered by master's new tests: Zend/tests/assert/expect_015.php

And fix the valgrind warning: https://gist.github.com/mbeccati/d4109974c5a82cf495a8

reeze added some commits Mar 3, 2015

Fixed bug #69174 (leaks when unused inner class use traits precedence)
This was uncovered by master's new tests: Zend/tests/assert/expect_015.php
@laruence

This comment has been minimized.

Copy link
Member

commented Mar 5, 2015

After reviewing, unfortunately, your fix is not fully correct and not well, first it crash with:

<?php
function test() {
    class C1 {
        use T1, T2 {
            T1::foo insteadof T2;
            T1::bar insteadof T2;
        }
    }
}

and you introduced a new no necessary flag.

I got a better fix, and committed in f039225

it also use less memory occupation.

please close this PR if you have no problems.

(sorry for delay, was busy with zend signals)

thanks

@reeze

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2015

Great!

@reeze reeze closed this Mar 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.