Typed constants in SPL extension - #12358
Merged
Merged
Conversation
kocsismate
reviewed
Oct 6, 2023
kocsismate
reviewed
Oct 6, 2023
kocsismate
left a comment
kocsismate
left a comment
Member
There was a problem hiding this comment.
LGTM, I'd be curious about other reviewer's comments though
Member
|
I'm also in favour, but this will require an entry in UPGRADING |
Contributor
Author
|
@Girgias, added note to the UPGRADING file. |
Girgias
approved these changes
Oct 7, 2023
adrian-enspired
pushed a commit
to adrian-enspired/php-src
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds typing to the class constants in SPL extension.