Skip to content

Convert bounds exception in SplFixedArray to OutOfBoundsException instead of RuntimeException #12383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2023
Merged

Convert bounds exception in SplFixedArray to OutOfBoundsException instead of RuntimeException #12383

merged 1 commit into from
Oct 8, 2023

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Oct 8, 2023

No description provided.

@nielsdos nielsdos requested a review from Girgias as a code owner October 8, 2023 16:10
Girgias
Girgias approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we wouldn't care about BC I would say to use a ValueError instead.

But this is a nice improvement.

@nielsdos nielsdos merged commit 009d48d into php:master Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: spl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias