Fix: pdo pgsql test 12423#12454
Merged
Merged
Conversation
SakiTakamachi
force-pushed
the
fix/pdo_pgsql_test_12423_2
branch
from
90e98a9 to
95cf409
Compare
Member
|
Whenever you can @mbeccati let us know if this work for you, cheers. |
Contributor
|
I had tested a previous version of the PR and it was ok, thanks! |
devnexen
reviewed
Oct 22, 2023
Member
There was a problem hiding this comment.
nit: While at it, would be best to use PHP_EOL instead.
Member
Author
There was a problem hiding this comment.
Thank you, I fixed it
Fix regular expression fix to use PHP_EOL
SakiTakamachi
force-pushed
the
fix/pdo_pgsql_test_12423_2
branch
from
95cf409 to
eb0fe60
Compare
Member
Author
|
My test is failing, but it might be flaky. |
Contributor
|
The build error doesn't seem related to this PR though: |
Member
|
No it is not related at all indeed. Will review a bit later today. Thanks. |
Member
Author
|
I was about to write that the flaky test may have failed in an unrelated place. I couldn't explain it well in English, thank you for check. |
devnexen
approved these changes
Oct 23, 2023
Member
Author
|
Thank you! |
Contributor
|
For reference, CI green again: https://revive.beccati.com/bamboo/browse/PHP-SRC-3566/ |
Member
Author
|
Thank you, I feel relieved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #12448
take2 of #12453
I missed the f push. So I recreated the entire PR.
cc: @mbeccati @devnexen
CI: https://app.circleci.com/pipelines/github/SakiTakamachi/php-src/9/workflows/8ff17a8a-1eb1-4f96-9167-5273775c76bd/jobs/9 (take2)
=> passed