Changed: Implementing improved error callback mechanism (php_error_cb) #1247
Conversation
Fixes "error: ‘core_globals_id’ undeclared" when PHP is compiled with --enable-maintainer-zts
Error hooks should normally return SUCCESS but they can return FAILURE in order to stop the processing of the current hook list as it is the case for the bailout one. It also has the benefit of standardizing the API for error hooks.
|
👍 |
| char *log_buffer; | ||
| #ifdef PHP_WIN32 | ||
| if (type == E_CORE_ERROR || type == E_CORE_WARNING) { | ||
| syslog(LOG_ALERT, "PHP %s: %s (%s)", error_type_str, buffer, GetCommandLine()); |
There was a problem hiding this comment.
This needs win32/syslog.h to be included. Or maybe it'd be better to check what header inclusion did provide it in the old file. For the rest it looks fine.
Thank you Anatol Belski for noticing.
| @@ -959,12 +960,26 @@ PHPAPI void php_html_puts(const char *str, size_t size) | |||
| } | |||
| /* }}} */ | |||
|
|
|||
| #define CALL_ERROR_HOOKS(HOOK_LIST) for ( \ | |||
There was a problem hiding this comment.
Why not make it inline function instead of macro? Would be much more readable.
There was a problem hiding this comment.
I have unpleasant experience with va_list and I guess I would have to va_copy/va_end once more if I am using a function rather than a macro, but more important than that, gcc has/had issues with va_list being passed to an inline function. Additionally, I guess that it wouldn't be inlined at all in the end, as it's just a hint for the compiler.
|
@patrickallaert fix conflicts please :) Also take this as a reminder to push forward with the RFC ... if you consider this work abandoned please close this PR. |
|
Having waited more than a month for this PR to be fixed, and since there are still merge conflicts, I'm closing this PR, and will update the RFC. Please take this action as encouragement to open a clean PR against a supported branch, and push forward with the RFC. |
PR for https://wiki.php.net/rfc/improved_error_callback_mechanism