Skip to content

Fix unused variable in phpdbg_cmd.c#12575

Merged
ndossche merged 1 commit into
php:masterfrom
mvorisek:fix_unused_phpdbg_sapi_var
Oct 31, 2023
Merged

Fix unused variable in phpdbg_cmd.c#12575
ndossche merged 1 commit into
php:masterfrom
mvorisek:fix_unused_phpdbg_sapi_var

Conversation

@mvorisek

@mvorisek mvorisek commented Oct 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor 
/usr/src/php/sapi/phpdbg/phpdbg_cmd.c:743:14: warning: unused variable 'buf' [-Wunused-variable]
  743 |         char buf[PHPDBG_MAX_CMD];
      |              ^~~

@mvorisek

mvorisek commented Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

Am I right this fix should target master only?

ndossche
ndossche approved these changes Oct 31, 2023
View reviewed changes

@ndossche ndossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
And yes, targeting master is right as this is a warning fix not a bugfix.

@ndossche ndossche merged commit cc8c24a into php:master Oct 31, 2023
@mvorisek mvorisek deleted the fix_unused_phpdbg_sapi_var branch October 31, 2023 08:52
@SVGAnimate SVGAnimate mentioned this pull request Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndossche ndossche ndossche approved these changes

Assignees

No one assigned

Labels

SAPI: phpdbg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvorisek @ndossche