Dereferencing process-handles no longer waits on those processes #130

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Jille
When handles created by proc_open() and popen() got destroyed they called waitpid() and waited for the process to exit. Now they only wait if they are explicitly closed with proc_close() or pclose().

Implements FR #46487

I will also send this over internals to be discussed.

@lstrojny

@Jille patch looks good. Can you add a test for your patch?

@lstrojny

Could you rebase and squash?

@Jille

I've committed f2bad2c to Jille/php-src:proc_close_lingering_squashed.

@lstrojny

Please force push to this PR as well.

@Jille

Done.

@lstrojny

Hm, the test is gone?

@Jille

I'm sorry. Fixed.

@php-pulls

Comment on behalf of lstrojny at php.net:

Merged into 5.5 and master. 5.5 and not 5.4 because it comes with an ABI break.

@php-pulls php-pulls closed this Jan 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment